From patchwork Fri Oct 12 10:36:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1586231 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 883EDDFF71 for ; Fri, 12 Oct 2012 10:40:34 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TMcc2-0005ZR-Ng; Fri, 12 Oct 2012 10:37:02 +0000 Received: from mail-vc0-f177.google.com ([209.85.220.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TMcbz-0005ZC-6g for linux-arm-kernel@lists.infradead.org; Fri, 12 Oct 2012 10:36:59 +0000 Received: by mail-vc0-f177.google.com with SMTP id p16so3422802vcq.36 for ; Fri, 12 Oct 2012 03:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=mnaFNvgakBSQVEEI1/7o5BOB3+Cg7/5RK6usDbuE494=; b=qYeTEbQewEs2Rnut5oQ1oSFHzt9QyMlK7Bgq93gpJFq2Mvai4rEJs6WUhLgopwaKqp jUL3e7y7HhgFig66uj+2QIWtq8kZLEbMampedUFhRDcPg7ktrmVLoZ/5ZhK5bHljdAcx 0LE8/xTIm3GJWWAID9XME65yfa0I4LC20A9XAmGUwswcyzE3u+tnvn50ztHewJf76oSb cO8phNE6Go9HnqKdluByRDzZP54AnyQOvmth9brDNpLdHleH2snaWDlWoxxjQuQCe0Z4 BmK7G8Gc1eBo5pJW2PSXi/MGlDkkPJUgSVvGflgwrmSwgGZw9lSjgav0XzzWAyDrWXLe glLg== MIME-Version: 1.0 Received: by 10.52.96.167 with SMTP id dt7mr1896097vdb.118.1350038217124; Fri, 12 Oct 2012 03:36:57 -0700 (PDT) Received: by 10.220.182.65 with HTTP; Fri, 12 Oct 2012 03:36:56 -0700 (PDT) In-Reply-To: <1350030203.10584.139.camel@smile> References: <142ef9170a2c69657d8a05ac127a9970d7b04965.1350020375.git.viresh.kumar@linaro.org> <91e41b4cc972d298f714cbd6f400569a9710304c.1350020375.git.viresh.kumar@linaro.org> <1350030203.10584.139.camel@smile> Date: Fri, 12 Oct 2012 16:06:56 +0530 X-Google-Sender-Auth: -mTNF55uILBS39lTb1sDM7zGYOU Message-ID: Subject: Re: [PATCH 2/3] dmaengine: dw_dmac: Enhance device tree support From: viresh kumar To: Andy Shevchenko X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (viresh.linux[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: vinod.koul@intel.com, devicetree-discuss@lists.ozlabs.org, spear-devel@list.st.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko wrote: > On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote: >> + while (++i < dw->sd_count) { >> + if (!strcmp(dw->sd[i].bus_id, param)) { >> + found = 1; >> + break; >> + } >> + } >> + >> + if (!found) { >> + last_dw = dw; >> + last_bus_id = param; >> + return false; > Because of return here you could eliminate 'found' flag at all. how? Fixed the other issue as: Author: Viresh Kumar Date: Fri Oct 12 16:06:32 2012 +0530 fixup! dmaengine: dw_dmac: Enhance device tree support --- drivers/dma/dw_dmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- viresh diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 9a7d084..a4ff04c 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -1598,9 +1598,10 @@ __devinit dw_dma_parse_dt(struct platform_device *pdev) return pdata; } #else -static inline int dw_dma_parse_dt(struct platform_device *pdev) +static inline struct dw_dma_platform_data * +dw_dma_parse_dt(struct platform_device *pdev) { - return -ENOSYS; + return NULL; } #endif