From patchwork Mon Jun 16 03:21:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 4355871 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 656B09F26E for ; Mon, 16 Jun 2014 03:24:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8C3F420260 for ; Mon, 16 Jun 2014 03:24:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A687A2020E for ; Mon, 16 Jun 2014 03:24:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WwNUl-0000cu-65; Mon, 16 Jun 2014 03:22:07 +0000 Received: from mail-vc0-f181.google.com ([209.85.220.181]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WwNUi-0000ZI-M2 for linux-arm-kernel@lists.infradead.org; Mon, 16 Jun 2014 03:22:05 +0000 Received: by mail-vc0-f181.google.com with SMTP id il7so4253501vcb.26 for ; Sun, 15 Jun 2014 20:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HeXWmPM9KQl0IL2WkDDmCyt3n/ijh6NU80/Gdk//Gmo=; b=HElkLfipneaQFnxQjWidp5Sm7E5XtDCctg9C421UGMu2iiKiA9sAa34+qyPuC4YTHR 3tVkNGm62NIkopvE87Ay2BSyQkGbaVwnw4IyzLTwziTjuClymKz4TfFg/IOJbNlxVlrz FWcLpZuIfmKuTmYQ11dJibyG/Yoj48i4P+vsTQKb1FK7L1cbNg6O0lSN3rli2Tgt80j5 Xkrxp+4A1OM6lgy1JfVHEBTfURqhJ8te1ijv2kkxrtkWT3qrn+4zQossUsEMSaszNAHa vig2yKM60U8wOd8tGngLWR6yaTaXwzifJ8auKf6ZZ5cFxniMecncxKMlFHi7fRJIny1A pH3g== MIME-Version: 1.0 X-Received: by 10.58.85.3 with SMTP id d3mr103412vez.34.1402888900026; Sun, 15 Jun 2014 20:21:40 -0700 (PDT) Received: by 10.221.53.5 with HTTP; Sun, 15 Jun 2014 20:21:39 -0700 (PDT) In-Reply-To: <20140615203058.GA22265@lukather> References: <1402769508-3821-1-git-send-email-xerofoify@gmail.com> <20140615203058.GA22265@lukather> Date: Sun, 15 Jun 2014 23:21:39 -0400 Message-ID: Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c From: Nick Krause To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140615_202204_801770_C323A4A2 X-CRM114-Status: GOOD ( 14.25 ) X-Spam-Score: -0.8 (/) Cc: =?UTF-8?Q?Emilio_L=C3=B3pez?= , Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP New Patch Just Fixed Typo for my email client. Signed-off-by: Nick --- drivers/clk/sunxi/clk-sunxi.c | 1 + 1 file changed, 1 insertion(+) /* allocate fixed-rate and gate clock structs */ Cheers Nick On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard wrote: > On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote: >> Signed-off-by: Nick > > This should be your full real name here. > >> --- >> drivers/clk/sunxi/clk-sunxi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c >> index 4264834..6f4fc51 100644 >> --- a/drivers/clk/sunxi/clk-sunxi.c >> +++ b/drivers/clk/sunxi/clk-sunxi.c >> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node) >> u32 rate; >> >> if (of_property_read_u32(node, "clock-frequency", &rate)) >> + kree(gate); > > There's a typo in kfree. How does that even compile? > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com diff --git a/drivers/clk/sunxi/clk-sunxi. c b/drivers/clk/sunxi/clk-sunxi.c index 4264834..6f4fc51 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node) u32 rate; if (of_property_read_u32(node, "clock-frequency", &rate)) + kfree(gate); return;