From patchwork Thu Nov 28 22:58:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 3256001 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 74C799F36A for ; Thu, 28 Nov 2013 22:59:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74AE9203F3 for ; Thu, 28 Nov 2013 22:59:34 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 888A620630 for ; Thu, 28 Nov 2013 22:59:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VmAYP-0006Ge-EP; Thu, 28 Nov 2013 22:59:25 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VmAYN-0004Qc-1s; Thu, 28 Nov 2013 22:59:23 +0000 Received: from mail-bk0-f46.google.com ([209.85.214.46]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VmAYH-0004QJ-AU for linux-arm-kernel@lists.infradead.org; Thu, 28 Nov 2013 22:59:20 +0000 Received: by mail-bk0-f46.google.com with SMTP id u15so4009108bkz.19 for ; Thu, 28 Nov 2013 14:58:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=J1K+dCpNQirDxbOHZYF3KUbKVN2W7VQmgfgav0FbaxA=; b=ES2sm4aqr9+GpL9SRN8JlN2P0VtpnmyUc0KqMsHAwpjsAetBl6owSgwhc1gv17YSa7 hW+ycguuPVgIOieX5/knRd6dZL+XLhmbzKiYy+MRZnektjnFvfEikNydHa5wbohlJN1/ H7D9XvMOAyEBT3G6atychoFXULt/n7AVh0U/MbMWzh5EjvubRUh7xzt9xknJiG8FUbLO uas2m+WaKEZt9DMxG65M1JzlSvx7tV4jKw4JI8gN3K+Tp9BuOfEHaHCOrQ9ZPohrzwOU mSitDJVMkUUJHPizu1KBb5LHrnL14OK8br1TL/whbB8SpZk7fbiVGX5P67LdXREHpI3A BktQ== X-Gm-Message-State: ALoCoQk0k7QCoZTJ9V6g503k1uZ50i4QGkmsBI7X0A4yKaE6pPylILUf4lCxCfiBp6PiSDbNVRdu MIME-Version: 1.0 X-Received: by 10.205.86.131 with SMTP id as3mr38551bkc.89.1385679533302; Thu, 28 Nov 2013 14:58:53 -0800 (PST) Received: by 10.205.44.200 with HTTP; Thu, 28 Nov 2013 14:58:53 -0800 (PST) Date: Thu, 28 Nov 2013 14:58:53 -0800 Message-ID: Subject: Build warning in drivers/dma/mmp_tdma.c From: Dan Williams To: Zhangfei Gao , Qiao Zhou , Leo Yan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131128_175917_473815_7FE830DB X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) Cc: "dmaengine@vger.kernel.org" , Vinod Koul , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP My build warning test is failing on this driver please fix: drivers/dma/mmp_tdma.c:236:8: warning: 'tdcr' may be used uninitialized in this function [-Wuninitialized] It's valid as mmp_tdma_control as the direction is specified in mmp_tdma_control() and may not be one of the two tests in that branch. I'm also carrying patch to add a missing dependency: commit 1a4ee91dacedde3e82d8ce6eeace7f16884474f9 Author: Dan Williams Date: Thu Nov 28 12:27:38 2013 -0800 dma: mmp_dma depends on CPU_MMP2 It calls sram_get_gpool() which is only defined if CONFIG_CPU_MMP2=y Signed-off-by: Dan Williams Is there a different ARCH type that this driver should be depending on? --- Dan diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 446687cc2334..dad83634cb65 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -287,7 +287,7 @@ config DMA_SA11X0 config MMP_TDMA bool "MMP Two-Channel DMA support" - depends on ARCH_MMP + depends on ARCH_MMP && CPU_MMP2 select DMA_ENGINE help Support the MMP Two-Channel DMA engine.