From patchwork Thu Sep 27 05:54:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1511731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id F2E973FDAE for ; Thu, 27 Sep 2012 05:56:23 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TH73e-00073l-SG; Thu, 27 Sep 2012 05:54:47 +0000 Received: from mail-qa0-f42.google.com ([209.85.216.42]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TH73W-00070D-1k for linux-arm-kernel@lists.infradead.org; Thu, 27 Sep 2012 05:54:38 +0000 Received: by qaat11 with SMTP id t11so614167qaa.15 for ; Wed, 26 Sep 2012 22:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=NyYKJB/LcgPYiIEGyg2n0jXzZK2nNJpRZKlw5yoRTn8=; b=DFWEOfKjGfwS6DWL/aU/VqHvlfTF7no0fna6fPZYyit4pxCSdIFhXMruUrooqtgO51 oY4stTcR2B8MWJF2h8di192Y7j7UwtG+dnDbTQhSUFcFZd+pkfSHTUAZjtcPdXeb4zSz C8veWS9HGKzrzA231DuyUONDWGdNyY9uW8qJ/XloIDQ5D8piT208Pn/PFDm0cJUAMBKS k523Bm1zZCeStYY09Sv9LPtvc3MxdvHXscMT4PIJLur7n4w/kx7OvID3ho9vnJvBbbAo 3pXYrA7inJ7tWkqbITPMRlK+O/8UnjGqzAXZfCCenwBsR6JkYoF2X7yBZcGk70Vie0+Q 4igA== MIME-Version: 1.0 Received: by 10.224.100.200 with SMTP id z8mr7228403qan.75.1348725276643; Wed, 26 Sep 2012 22:54:36 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Wed, 26 Sep 2012 22:54:36 -0700 (PDT) Date: Thu, 27 Sep 2012 13:54:36 +0800 Message-ID: Subject: [PATCH] ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage() From: Wei Yongjun To: khilman@ti.com, tony@atomide.com, linux@arm.linux.org.uk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.42 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Acked-by: Jean Pihet --- arch/arm/mach-omap2/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 9cb5ced..ab15e5c 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2/pm.c @@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, } voltdm = voltdm_lookup(vdd_name); - if (IS_ERR(voltdm)) { + if (!voltdm) { pr_err("%s: unable to get vdd pointer for vdd_%s\n", __func__, vdd_name); goto exit;