diff mbox

[-next] dmaengine: ste_dma40: add missing iounmap() on error in d40_probe()

Message ID CAPgLHd9kMzZ_ZY6zm0MZ+P6dHq73i_GdCsxhpUOt-V9nf08tWA@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun May 28, 2013, 9:07 a.m. UTC 
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Add the missing iounmap() before return from d40_probe()
in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/dma/ste_dma40.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Linus Walleij May 29, 2013, 3:46 p.m. UTC | #1 
Hi Wei,

why does the patch subject say -next?

AFAICS the patch applies to Torvalds tree as well, and should probably
go in for fixes.

On Tue, May 28, 2013 at 11:07 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing iounmap() before return from d40_probe()
> in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I guess Vinod should apply this... maybe it should even be marked
for stable.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 71bf4ec..018c2f7 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3612,6 +3612,8 @@  failure:
 			kmem_cache_destroy(base->desc_slab);
 		if (base->virtbase)
 			iounmap(base->virtbase);
+		if (base->lcpa_base)
+			iounmap(base->lcpa_base);
 
 		if (base->lcla_pool.base && base->plat_data->use_esram_lcla) {
 			iounmap(base->lcla_pool.base);