From patchwork Tue May 28 09:07:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2623671 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 78FF3DFB78 for ; Tue, 28 May 2013 09:08:42 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhFtP-0002P0-Mm; Tue, 28 May 2013 09:08:32 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhFtC-0008VU-UY; Tue, 28 May 2013 09:08:18 +0000 Received: from mail-bk0-x234.google.com ([2a00:1450:4008:c01::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UhFtA-0008V1-3A for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2013 09:08:16 +0000 Received: by mail-bk0-f52.google.com with SMTP id mz10so4004694bkb.25 for ; Tue, 28 May 2013 02:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=7W5Fe9APv1CAUn9snUt/Ck3kdLj6PHJKbWII9aLZKaM=; b=LJXyTT6w8166fdasMTbg26PbDDZLOt2517tM7KsxdoGgr9hkcWp8eFxloH7hvGkDz0 nv1Rf56VIs/xBlRCYax2MRUnr5kgBbt9ZG1DefUGsbbJXbC5fPUHUe1COnj5JuscPpmO bqr1x6v8z9VvbMddsK8Xj8fZZvPpQJwXBClWykqWm5GZuhTtp7WV8qlPa0WQFc0jcC1Q qfrbg/RdkZuMS0ByZT6mAi0/jFIHs0BqxQ4Y0WWkQFql5jdIxDuFQ41wXSk4yzY1+Di8 LCF50FesHJhletkn6mtgk/ZCg08snlyuKdKuLsXSpwstguaCEtgdHa4FB7HvB/YeNa+6 6CRw== MIME-Version: 1.0 X-Received: by 10.204.189.134 with SMTP id de6mr12414436bkb.126.1369732074085; Tue, 28 May 2013 02:07:54 -0700 (PDT) Received: by 10.204.39.1 with HTTP; Tue, 28 May 2013 02:07:54 -0700 (PDT) Date: Tue, 28 May 2013 17:07:54 +0800 Message-ID: Subject: [PATCH -next] dmaengine: ste_dma40: add missing iounmap() on error in d40_probe() From: Wei Yongjun To: srinidhi.kasagar@stericsson.com, linus.walleij@linaro.org, djbw@fb.com, vinod.koul@intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130528_050816_487107_BC577099 X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun Add the missing iounmap() before return from d40_probe() in the error handling case. Signed-off-by: Wei Yongjun Acked-by: Linus Walleij --- drivers/dma/ste_dma40.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 71bf4ec..018c2f7 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3612,6 +3612,8 @@ failure: kmem_cache_destroy(base->desc_slab); if (base->virtbase) iounmap(base->virtbase); + if (base->lcpa_base) + iounmap(base->lcpa_base); if (base->lcla_pool.base && base->plat_data->use_esram_lcla) { iounmap(base->lcla_pool.base);