From patchwork Sun Oct 7 13:58:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1561291 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id CBD70DFF71 for ; Sun, 7 Oct 2012 14:01:02 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TKrNj-0002Z3-Kd; Sun, 07 Oct 2012 13:58:59 +0000 Received: from mail-qc0-f172.google.com ([209.85.216.172]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TKrNg-0002Yp-U2 for linux-arm-kernel@lists.infradead.org; Sun, 07 Oct 2012 13:58:57 +0000 Received: by mail-qc0-f172.google.com with SMTP id c10so2702777qca.17 for ; Sun, 07 Oct 2012 06:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=WvNfqJYRwzjRqKjAcHqzoF2D7xAAByl3oL3psQKUZho=; b=0eEhq4AE4VZr/KTwjO2zQrt79pCZDwR7iHzZSxO9Gs962bn2yHtYFnlMTyL5R61Z48 dq0zt78rdQRhNS6i4sGC4g1DxXzX/vDcikQuqFMLNOtFEvw3i7Lfzj61+YDdCmPsgSrW 3aG9ETG4EZF0Nmyf6/UOxOyIswxUKjJz85x+g35Q3P6S4Pr9rDIF7fMDDrx2em1Ntm34 vIS7zwMLoyFzeaFLKleRqB8TYq3dP76q/NiWaHc9IkQFDpMG6ojxh9G5sj/vzlPwir1m LnUcGe7Ndfq+7wsd/93njlqHCBxxDnkKdhXUqgT/HFm/I0v1FvBE8KyhD10oL3H3eZUn Hplw== MIME-Version: 1.0 Received: by 10.49.14.228 with SMTP id s4mr36879235qec.4.1349618335215; Sun, 07 Oct 2012 06:58:55 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Sun, 7 Oct 2012 06:58:55 -0700 (PDT) Date: Sun, 7 Oct 2012 21:58:55 +0800 Message-ID: Subject: [PATCH] ARM: OMAP: fix return value check in realtime_counter_init() From: Wei Yongjun To: tony@atomide.com, linux@arm.linux.org.uk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.172 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (weiyj.lk[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Wei Yongjun In case of error, the function clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- arch/arm/mach-omap2/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 8847d6e..44f9aa7 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -378,7 +378,7 @@ static void __init realtime_counter_init(void) return; } sys_clk = clk_get(NULL, "sys_clkin_ck"); - if (!sys_clk) { + if (IS_ERR(sys_clk)) { pr_err("%s: failed to get system clock handle\n", __func__); iounmap(base); return;