From patchwork Fri Jul 12 13:20:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2826930 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D49A99F7D6 for ; Fri, 12 Jul 2013 13:27:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C571A2012C for ; Fri, 12 Jul 2013 13:26:59 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8799C20125 for ; Fri, 12 Jul 2013 13:26:58 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UxdN8-0004pY-UW; Fri, 12 Jul 2013 13:26:55 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UxdN6-0000am-Fc; Fri, 12 Jul 2013 13:26:52 +0000 Received: from mail-bk0-x229.google.com ([2a00:1450:4008:c01::229]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UxdN2-0000aJ-6r for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2013 13:26:50 +0000 Received: by mail-bk0-f41.google.com with SMTP id jc3so3855706bkc.28 for ; Fri, 12 Jul 2013 06:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=P5/ls5S1rhgrpTXbJ649aVT1oK4xi0wbHPBzTqusv1A=; b=WLDkOnLhvSEDlwv/2Z5ZRmHTJp98JsiG2Jujh8Z3SwuuIiiY7wd3WMPTuhDEO/hxJs qbDIjiMcbhvdzwhzC5nb12CQgS7Sl3DFdHj8oPuh6swHYGdeH2ymWQEbws6CDiHm4DXV WUrBghPW4sRi3LR7USdbFuGZMbt1mYJAbLQnuJS600k3Ooz723irMZvuMBewOlVEmq1X 0ngHA09rrkmihNPGS1jdrItCmU5b1bq5hyPcbIsxryhYBJ+DWw5V/dl4xmpWEO7Khdfv rJviWjmnuhJXBWog9i5Vs6zaRhILxypGokMV2pQyBLa8r9LZZ0k9eBB6yvNdq1eSppG0 WxIg== MIME-Version: 1.0 X-Received: by 10.204.189.80 with SMTP id dd16mr6274722bkb.126.1373635223204; Fri, 12 Jul 2013 06:20:23 -0700 (PDT) Received: by 10.205.122.72 with HTTP; Fri, 12 Jul 2013 06:20:23 -0700 (PDT) Date: Fri, 12 Jul 2013 21:20:23 +0800 Message-ID: Subject: [PATCH] video: nuc900fb: fix to pass correct device identity to free_irq() From: Wei Yongjun To: mcuos.com@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130712_092648_389922_23E0E695 X-CRM114-Status: GOOD ( 11.04 ) X-Spam-Score: -2.0 (--) Cc: yongjun_wei@trendmicro.com.cn, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun free_irq() expects the same device identity that was passed to corresponding request_irq(), otherwise the IRQ is not freed. Signed-off-by: Wei Yongjun --- drivers/video/nuc900fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index 8c527e5..ebd5501 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -661,7 +661,7 @@ release_clock: clk_disable(fbi->clk); clk_put(fbi->clk); release_irq: - free_irq(irq, fbi); + free_irq(irq, fbinfo); release_regs: iounmap(fbi->io); release_mem_region: @@ -702,7 +702,7 @@ static int nuc900fb_remove(struct platform_device *pdev) iounmap(fbi->io); irq = platform_get_irq(pdev, 0); - free_irq(irq, fbi); + free_irq(irq, fbinfo); release_resource(fbi->mem); kfree(fbi->mem);