diff mbox

[02/97] ARM: l2c: remove unnecessary call to outer_flush_all()

Message ID E1WerBl-0007V2-Kf@rmk-PC.arm.linux.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Russell King April 28, 2014, 7:26 p.m. UTC
outer_disable() is defined to safely turn the L2 cache off without data
loss: this means that outer_flush_all() should never be called unless
you need to implement some special L2 cache disabling, and even then
only from your replacement L2 cache disable function.

Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/mach-prima2/pm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Barry Song May 2, 2014, 3:48 p.m. UTC | #1
2014-04-29 3:26 GMT+08:00, Russell King <rmk+kernel@arm.linux.org.uk>:
> outer_disable() is defined to safely turn the L2 cache off without data
> loss: this means that outer_flush_all() should never be called unless
> you need to implement some special L2 cache disabling, and even then
> only from your replacement L2 cache disable function.
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Acked-by: Barry Song <Baohua.Song@csr.com>

> ---
>  arch/arm/mach-prima2/pm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-prima2/pm.c b/arch/arm/mach-prima2/pm.c
> index c4525a88e5da..96e9bc102117 100644
> --- a/arch/arm/mach-prima2/pm.c
> +++ b/arch/arm/mach-prima2/pm.c
> @@ -71,7 +71,6 @@ static int sirfsoc_pm_enter(suspend_state_t state)
>  	case PM_SUSPEND_MEM:
>  		sirfsoc_pre_suspend_power_off();
>
> -		outer_flush_all();
>  		outer_disable();
>  		/* go zzz */
>  		cpu_suspend(0, sirfsoc_finish_suspend);
> --
> 1.8.3.1
>
>
diff mbox

Patch

diff --git a/arch/arm/mach-prima2/pm.c b/arch/arm/mach-prima2/pm.c
index c4525a88e5da..96e9bc102117 100644
--- a/arch/arm/mach-prima2/pm.c
+++ b/arch/arm/mach-prima2/pm.c
@@ -71,7 +71,6 @@  static int sirfsoc_pm_enter(suspend_state_t state)
 	case PM_SUSPEND_MEM:
 		sirfsoc_pre_suspend_power_off();
 
-		outer_flush_all();
 		outer_disable();
 		/* go zzz */
 		cpu_suspend(0, sirfsoc_finish_suspend);