| Message ID | E1axXS5-0004h5-Cb@e0050434b2927.dyn.arm.linux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 3, 2016 at 3:51 PM, Russell King <rmk@arm.linux.org.uk> wrote: > generate_new_headers() forgot to increment the program header pointer > after adding each program header from the kexec template. Fix it to > increment it correctly. > > Without this, the program headers contain only the last entry, which > means we will be missing most of the kernel image in the dump. > > Signed-off-by: Russell King <rmk@arm.linux.org.uk> Reviewed-by: Pratyush Anand <panand@redhat.com> > --- > kdump/kdump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kdump/kdump.c b/kdump/kdump.c > index 3247a54..99a1789 100644 > --- a/kdump/kdump.c > +++ b/kdump/kdump.c > @@ -192,6 +192,7 @@ static void *generate_new_headers( > } > memcpy(nphdr, &phdr[i], sizeof(*nphdr)); > nphdr->p_offset = offset; > + nphdr++; > offset += phdr[i].p_filesz; > } > > -- > 1.9.1 >
diff --git a/kdump/kdump.c b/kdump/kdump.c index 3247a54..99a1789 100644 --- a/kdump/kdump.c +++ b/kdump/kdump.c @@ -192,6 +192,7 @@ static void *generate_new_headers( } memcpy(nphdr, &phdr[i], sizeof(*nphdr)); nphdr->p_offset = offset; + nphdr++; offset += phdr[i].p_filesz; }
generate_new_headers() forgot to increment the program header pointer after adding each program header from the kexec template. Fix it to increment it correctly. Without this, the program headers contain only the last entry, which means we will be missing most of the kernel image in the dump. Signed-off-by: Russell King <rmk@arm.linux.org.uk> --- kdump/kdump.c | 1 + 1 file changed, 1 insertion(+)