| Message ID | E1eRnWl-0006VL-TL@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 20, 2017 at 11:11:55PM +0000, Russell King wrote: > Switch 2 has an 88e1545 PHY behind it, which is a quad PHY. Only the > first three PHYs are used, the remaining PHY is unused. When we wire > up the SFF sockets in a later commit, the omission of this causes the > fourth PHY to be used for port 3. Specifying the PHYs in DT avoids > the auto-probing of the bus, and discovery of this PHY. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Thu, Dec 21, 2017 at 12:11 AM, Russell King <rmk+kernel@armlinux.org.uk> wrote: > Switch 2 has an 88e1545 PHY behind it, which is a quad PHY. Only the > first three PHYs are used, the remaining PHY is unused. When we wire > up the SFF sockets in a later commit, the omission of this causes the > fourth PHY to be used for port 3. Specifying the PHYs in DT avoids > the auto-probing of the bus, and discovery of this PHY. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Ah this is elegant and what Andrew requested me to do for another switch as well. Makes perfect sense. FWIW: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index ede8649ba515..782b69a3acdf 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts @@ -255,16 +255,19 @@ port@0 { reg = <0>; label = "lan6"; + phy-handle = <&switch2phy0>; }; port@1 { reg = <1>; label = "lan7"; + phy-handle = <&switch2phy1>; }; port@2 { reg = <2>; label = "lan8"; + phy-handle = <&switch2phy2>; }; port@3 { @@ -304,6 +307,20 @@ }; }; }; + mdio { + #address-cells = <1>; + #size-cells = <0>; + + switch2phy0: phy@0 { + reg = <0>; + }; + switch2phy1: phy@1 { + reg = <1>; + }; + switch2phy2: phy@2 { + reg = <2>; + }; + }; }; };
Switch 2 has an 88e1545 PHY behind it, which is a quad PHY. Only the first three PHYs are used, the remaining PHY is unused. When we wire up the SFF sockets in a later commit, the omission of this causes the fourth PHY to be used for port 3. Specifying the PHYs in DT avoids the auto-probing of the bus, and discovery of this PHY. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)