From patchwork Wed Jan 24 15:36:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 10182741 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40BF460567 for ; Wed, 24 Jan 2018 15:37:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D43828581 for ; Wed, 24 Jan 2018 15:37:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 21D4E28910; Wed, 24 Jan 2018 15:37:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 94F8128581 for ; Wed, 24 Jan 2018 15:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id: In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: References:List-Owner; bh=mR5ffSucUNttKJ671MEvTUxfMS4gJRQQ036XT27KetY=; b=gGO MgvI2Gp5eGzDHpib+uOEETMe+plBWt/QUX/++BcPAYrIG9B8pbXvCHtjNlGbXf0nX2Y1gmpL4pJ1y ViI1dIGhPqKGTP8Ug1WwZoFNNn3/OO6VZ9AHuasxkwsVxW0T9yNgaemPyRitBAb/H6iV8JeKPgJzH FsvqHq1gi1iAUBJTWS7J9kWpL0ldGBSy3e25H4e04dICSF5Q06YO1g9JaXcPblzSRAB0C/Xxy/5Ii uav8ehelK25cjUQkOuoTi6mqhcUqPKxFb9MOHuYbW1XLYnDneEXMz0n47IrTTjJvKCZxklD7B0OiO MRVdh/1KuNq6xfQsm+Lr3j2kL9tSnEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eeN7A-0002EN-FX; Wed, 24 Jan 2018 15:37:28 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eeN6x-0001yG-Oz for linux-arm-kernel@bombadil.infradead.org; Wed, 24 Jan 2018 15:37:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Date:Message-Id:In-Reply-To:Subject:Cc: To:From:Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ic/FEt6l3EdDa+eSL/2FrHkJU+AIpcjQhQ+1D7gop5g=; b=enGhdnxYkUtxfTsg5FB3YFGKZk h8k/ue2tV4l1SO92Iz3vFEItlZ9qWjktxZPCGp+SZNbmXxlY/QIVNZ97cXEdzwiRoTUMJAyvMfaqB QwRancYqTtBWx/mNE21gcI3KJIC7TEd4lPiqcavXtXNMfI12qjtkfFmKFoCQ+r8p4b5mMFsiCAKoQ +ZsR7nSB55CzmoRLNPOAkWJam6hoBmOJYnepa4itpx5VNNVuTYsVyVUIDGib8vOYoCAgVg3qrEq+J KC1oj+Y35IbavvFDn9daspDz4yFeJHq49op9PiGWU8f5X7cGRyV6A0ohSCBjSuAluTPem5c0KA2Zn zteRsV1Q==; Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by merlin.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eeN6u-0008Sr-91 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jan 2018 15:37:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=ic/FEt6l3EdDa+eSL/2FrHkJU+AIpcjQhQ+1D7gop5g=; b=iGk0yRmeBBNd yE63Xi5LWih3g86Z2UEURbrHcRL5dKFkUIwQmWT5RuP2ZQg9OffcnapF4HQAowXLlHnmatTPOLBmr tg6lPl1XNtNZHcAACNEHIdRbS1Nb64xu14Exe9huggDuLIaoCIbrWf+B7bJJfTqR2fokGKOu1OJJJ +xAw8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eeN67-0004Jr-Sl; Wed, 24 Jan 2018 15:36:23 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1eeN67-0004sJ-Dj; Wed, 24 Jan 2018 15:36:23 +0000 From: Mark Brown To: Maxime Chevallier Subject: Applied "spi: a3700: Remove endianness swapping functions when accessing FIFOs" to the spi tree In-Reply-To: <1516803048-26942-2-git-send-email-maxime.chevallier@smile.fr> Message-Id: Date: Wed, 24 Jan 2018 15:36:23 +0000 X-Bad-Reply: In-Reply-To but no 'Re:' in Subject. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.clement@free-electrons.com, broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The patch spi: a3700: Remove endianness swapping functions when accessing FIFOs has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 162f8debc01f48ac984ed6d7291743053ec90271 Mon Sep 17 00:00:00 2001 From: Maxime Chevallier Date: Wed, 24 Jan 2018 15:10:47 +0100 Subject: [PATCH] spi: a3700: Remove endianness swapping functions when accessing FIFOs Fixes the following sparse warnings : line 504: warning: incorrect type in assignment (different base types) line 504: expected unsigned int [unsigned] [usertype] val line 504: got restricted __le32 [usertype] line 527: warning: cast to restricted __le32 This is solved by removing endian-converson functions, since the converted values are going through readl/writel anyway, which take care of the conversion. Fixes: 6fd6fd68c9e2 ("spi: armada-3700: Fix padding when sending not 4-byte aligned data") Signed-off-by: Maxime Chevallier Reviewed-by: Gregory CLEMENT Signed-off-by: Mark Brown --- drivers/spi/spi-armada-3700.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index fdc35dabcda2..f32b83c7209f 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -493,7 +493,7 @@ static int a3700_spi_fifo_write(struct a3700_spi *a3700_spi) u32 val; while (!a3700_is_wfifo_full(a3700_spi) && a3700_spi->buf_len) { - val = cpu_to_le32(*(u32 *)a3700_spi->tx_buf); + val = *(u32 *)a3700_spi->tx_buf; spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val); a3700_spi->buf_len -= 4; a3700_spi->tx_buf += 4; @@ -516,9 +516,8 @@ static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi) while (!a3700_is_rfifo_empty(a3700_spi) && a3700_spi->buf_len) { val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG); if (a3700_spi->buf_len >= 4) { - u32 data = le32_to_cpu(val); - memcpy(a3700_spi->rx_buf, &data, 4); + memcpy(a3700_spi->rx_buf, &val, 4); a3700_spi->buf_len -= 4; a3700_spi->rx_buf += 4;