From patchwork Thu Feb 8 15:41:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 10207301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F333E60247 for ; Thu, 8 Feb 2018 15:42:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E387822230 for ; Thu, 8 Feb 2018 15:42:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D859026246; Thu, 8 Feb 2018 15:42:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9FB4E22230 for ; Thu, 8 Feb 2018 15:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id: In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: References:List-Owner; bh=dxIo92T3lrnxEmss8HkFira48czbmCZVrZBZVrqZUAA=; b=Tcw 9G34rEFT4K2da9w/58b1Gjzrz2QsG4uL1b9DXUPq2n17G46ifUXvVZ6Vpov+/LrkGSH3FfxFMApdL HB6/UV4FSbehcUw4SpHjUW97UUUw3hRt9CyRanZq9qwOckjvmGbYyYo9hpSwlHAwPzrpZatNjUdmx YYHlZEe8EuHz6T2wsIh6wJAUJ2NgohUcn3QvLUQOZZsY+NlmLQzI8PjKDfLMBQpL32LBWIVL2PVye EmqZwm6tQ/N8kFBs9JXNQh3YRwy8jb4W78wmgGEZbC6g8Ta5evfcV5MgvYY+uBHeZEZkjOXatAxsN cdYj3P+1sIkl3GMoXAmc0gZNfWQLsGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ejoLZ-0003jx-G0; Thu, 08 Feb 2018 15:42:49 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ejoLX-0003jl-QM for linux-arm-kernel@bombadil.infradead.org; Thu, 08 Feb 2018 15:42:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Date:Message-Id:In-Reply-To:Subject:Cc: To:From:Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BOsVEKMcNS2QUbk3PwJtlK0ZRUB0pD7GncqukDWtGKs=; b=Tc4+Y0R1F8PpaIJ73QOYLs/aHb rmhcW5agba9QRHNQyNSKLSjOLAkX0VM41BBG6/RVNtnvXIRikhLLOB9pTUITZFzskyKISzLSoiv2L DCF7YYCbI0UFVuc7J3R/M/uhAt5/Cf4JJKqePeRwPfU5s4aMRmRTXO3hEhY4pwGBlukCcVM59S+L7 0/Z1TWkQy+HygpNGJrha2O3CreQBtPM64S7tp4CfAXy93S7rvKlG3cqgr0p+/GcY+8c9SDgrJTlH9 ZA3BJPgD3+FiTe+CaytjpMUtnuoTO5nHRphJ//aRnxIAUaWXqK57mxfj1lja6ekom+wbHYwBjZukX Nt/LMWrA==; Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by casper.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ejoLU-0002tm-BG for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2018 15:42:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=BOsVEKMcNS2QUbk3PwJtlK0ZRUB0pD7GncqukDWtGKs=; b=Qlk9wntXGenb tC9rCt77q8achl9D732WzL8gPGxTx99zmQlC7eu2k5KTvOES1ZuYvM6XTIOrGCZ3fIfyk0NG6o7j/ gJW1RQACKnsVjg6g2es8GVHrj2aDcmLRiuX5RIiwk7o99Fki30d9nAVIvcpANecR65eM3aK7MfNTS 1jpv4=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejoKk-00036P-Ay; Thu, 08 Feb 2018 15:41:58 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1ejoKj-00006C-SN; Thu, 08 Feb 2018 15:41:57 +0000 From: Mark Brown To: Fabrice Gasnier Subject: Applied "regulator: stm32-vrefbuf: fix check on ready flag" to the regulator tree In-Reply-To: <1518097385-7449-1-git-send-email-fabrice.gasnier@st.com> Message-Id: Date: Thu, 08 Feb 2018 15:41:57 +0000 X-Bad-Reply: In-Reply-To but no 'Re:' in Subject. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180208_154244_401997_83EFBEEE X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, lgirdwood@gmail.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The patch regulator: stm32-vrefbuf: fix check on ready flag has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f63248fac563125fd5a2f0bc780ce7a299872cab Mon Sep 17 00:00:00 2001 From: Fabrice Gasnier Date: Thu, 8 Feb 2018 14:43:05 +0100 Subject: [PATCH] regulator: stm32-vrefbuf: fix check on ready flag stm32_vrefbuf_enable() wrongly checks VRR bit: 0 stands for not ready, 1 for ready. It currently checks the opposite. This makes enable routine to exit immediately without waiting for ready flag. Fixes: 0cdbf481e927 ("regulator: Add support for stm32-vrefbuf") Signed-off-by: Fabrice Gasnier Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- drivers/regulator/stm32-vrefbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/stm32-vrefbuf.c b/drivers/regulator/stm32-vrefbuf.c index 72c8b3e1022b..e0a9c445ed67 100644 --- a/drivers/regulator/stm32-vrefbuf.c +++ b/drivers/regulator/stm32-vrefbuf.c @@ -51,7 +51,7 @@ static int stm32_vrefbuf_enable(struct regulator_dev *rdev) * arbitrary timeout. */ ret = readl_poll_timeout(priv->base + STM32_VREFBUF_CSR, val, - !(val & STM32_VRR), 650, 10000); + val & STM32_VRR, 650, 10000); if (ret) { dev_err(&rdev->dev, "stm32 vrefbuf timed out!\n"); val = readl_relaxed(priv->base + STM32_VREFBUF_CSR);