From patchwork Wed Nov 28 11:12:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 10702335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B759109C for ; Wed, 28 Nov 2018 11:12:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 192872D013 for ; Wed, 28 Nov 2018 11:12:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DA3D2D02E; Wed, 28 Nov 2018 11:12:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ADD0E2D013 for ; Wed, 28 Nov 2018 11:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:MIME-Version:Subject: In-reply-to:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=vfLG+289iRhF/cKo12IkTrvl+S+TF3QiUO+PMP7YPy0=; b=XBBG4mrEHHZhkW XZpxuAz8DTvJyMn9Shwo08mCt5RpclfhRb8AzAS2HtJrdiEybh44vOvT3Y8fKbFOTNk+ep4mAzwrY IyylBZ0+6L4jqwKP2Fs5sWg+oBVYet05M9xUVToNHnPD63yV1j1Wfs8VT3BfZgkmjGQ8cPKW3pahA fBq4ncTc4JDZQAPotQP2xLWMihWbnfJy5erm4ljf2AjmMRCLZjI2BjBpmdAmCdNgJZuYvepZonvFR lRWPQEAI8MB4ibdaXN2JDHqtNU7setIJFExoHXF1HJrDq6TF43abXekicPXYhH9cJNFwyCSvmNjCA VsecuIatd51R4poxQsuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gRxlp-0008As-Nc; Wed, 28 Nov 2018 11:12:41 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gRxli-00083N-FW for linux-arm-kernel@lists.infradead.org; Wed, 28 Nov 2018 11:12:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:In-reply-to:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FvEXJ6cCI+IMdC7DbkV8V4bO5ftMbd7ERMygJr0xQoA=; b=pvbxJ/r5iIIzs5twBDy8Nlcybv jT2NLaZUGQSIxGfgGxSoqbTrQ7DzeAarfTkwimwMUmDNigBa7MBTd1CK51vlmYIBtbpsQABbf3ylr UsD1kyVJAWO+krSJF/1v2tBTa5AulEWjLjIyxccweGKEXNvRUFtXytRZ7bZjISyiNbYo=; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:45926 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1gRxlN-0004Jc-KM; Wed, 28 Nov 2018 11:12:13 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1gRxlI-0001vY-HP; Wed, 28 Nov 2018 11:12:08 +0000 From: Russell King To: linux-arm-kernel@lists.infradead.org In-reply-to: <20181128111041.GG30658@n2100.armlinux.org.uk> Subject: [PATCH 7/8] pcmcia: sa1100*: remove redundant bvd1/bvd2 setting MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Wed, 28 Nov 2018 11:12:08 +0000 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181128_031234_573902_8AD58381 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haojian Zhuang , Kristoffer Ericson , Robert Jarzmik , Dominik Brodowski , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP bvd1 and bvd2 both default to 1 in the generic soc_common code, so having a driver repeat this is redundant. Remove it. Signed-off-by: Russell King --- drivers/pcmcia/sa1100_simpad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pcmcia/sa1100_simpad.c b/drivers/pcmcia/sa1100_simpad.c index e235ee14eaa6..e2e8729afd9d 100644 --- a/drivers/pcmcia/sa1100_simpad.c +++ b/drivers/pcmcia/sa1100_simpad.c @@ -39,8 +39,8 @@ simpad_pcmcia_socket_state(struct soc_pcmcia_socket *skt, { long cs3reg = simpad_get_cs3_ro(); - state->bvd1 = 1; /* Might be cs3reg & PCMCIA_BVD1 */ - state->bvd2 = 1; /* Might be cs3reg & PCMCIA_BVD2 */ + /* bvd1 might be cs3reg & PCMCIA_BVD1 */ + /* bvd2 might be cs3reg & PCMCIA_BVD2 */ if ((cs3reg & (PCMCIA_VS1|PCMCIA_VS2)) == (PCMCIA_VS1|PCMCIA_VS2)) {