diff mbox series

arm64: dts: marvell: add missing #interrupt-cells property

Message ID E1hcsxH-0007Vv-0l@rmk-PC.armlinux.org.uk (mailing list archive)
State New, archived
Headers show
Series arm64: dts: marvell: add missing #interrupt-cells property | expand

Commit Message

Russell King (Oracle) June 17, 2019, 2:49 p.m. UTC
The GPIO interrupt controllers are missing their required
#interrupt-cells property, which prevents GPIO interrupts being
specified in DT.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Alexandre Belloni June 18, 2019, 8:17 a.m. UTC | #1
On 17/06/2019 15:49:55+0100, Russell King wrote:
> The GPIO interrupt controllers are missing their required
> #interrupt-cells property, which prevents GPIO interrupts being
> specified in DT.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index 4d6e4a097f72..f71afb1de18f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -238,6 +238,7 @@
>  					<85 IRQ_TYPE_LEVEL_HIGH>,
>  					<84 IRQ_TYPE_LEVEL_HIGH>,
>  					<83 IRQ_TYPE_LEVEL_HIGH>;
> +				#interrupt-cells = <2>;
>  				status = "disabled";
>  			};
>  
> @@ -253,6 +254,7 @@
>  					<81 IRQ_TYPE_LEVEL_HIGH>,
>  					<80 IRQ_TYPE_LEVEL_HIGH>,
>  					<79 IRQ_TYPE_LEVEL_HIGH>;
> +				#interrupt-cells = <2>;
>  				status = "disabled";
>  			};
>  		};
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Gregory CLEMENT June 18, 2019, 8:20 a.m. UTC | #2
Hi Russell,

> On 17/06/2019 15:49:55+0100, Russell King wrote:
>> The GPIO interrupt controllers are missing their required
>> #interrupt-cells property, which prevents GPIO interrupts being
>> specified in DT.
>> 
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Applied on mvebu/dt64

Thanks,

Gregory

>
>> ---
>>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 4d6e4a097f72..f71afb1de18f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -238,6 +238,7 @@
>>  					<85 IRQ_TYPE_LEVEL_HIGH>,
>>  					<84 IRQ_TYPE_LEVEL_HIGH>,
>>  					<83 IRQ_TYPE_LEVEL_HIGH>;
>> +				#interrupt-cells = <2>;
>>  				status = "disabled";
>>  			};
>>  
>> @@ -253,6 +254,7 @@
>>  					<81 IRQ_TYPE_LEVEL_HIGH>,
>>  					<80 IRQ_TYPE_LEVEL_HIGH>,
>>  					<79 IRQ_TYPE_LEVEL_HIGH>;
>> +				#interrupt-cells = <2>;
>>  				status = "disabled";
>>  			};
>>  		};
>> -- 
>> 2.7.4
>> 
>> 
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> -- 
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
index 4d6e4a097f72..f71afb1de18f 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
@@ -238,6 +238,7 @@ 
 					<85 IRQ_TYPE_LEVEL_HIGH>,
 					<84 IRQ_TYPE_LEVEL_HIGH>,
 					<83 IRQ_TYPE_LEVEL_HIGH>;
+				#interrupt-cells = <2>;
 				status = "disabled";
 			};
 
@@ -253,6 +254,7 @@ 
 					<81 IRQ_TYPE_LEVEL_HIGH>,
 					<80 IRQ_TYPE_LEVEL_HIGH>,
 					<79 IRQ_TYPE_LEVEL_HIGH>;
+				#interrupt-cells = <2>;
 				status = "disabled";
 			};
 		};