| Message ID | E1lmZTB-0005UP-C9@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] ARM: change vmalloc_min to be unsigned long | expand |
On Fri, May 28, 2021 at 12:11 PM Russell King (Oracle) <rmk+kernel@armlinux.org.uk> wrote: > > Rather than using "m" (which is the unit of metres, or milli), and > "MB" in the printk statements, use MiB to make it clear that we are > talking about the power-of-2 megabytes, aka mebibytes. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 5/28/21 6:11 PM, Russell King (Oracle) wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > Rather than using "m" (which is the unit of metres, or milli), and > "MB" in the printk statements, use MiB to make it clear that we are > talking about the power-of-2 megabytes, aka mebibytes. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Yanfei Xu <yanfei.xu@windriver.com> Regards, Yanfei > --- > arch/arm/mm/mmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index d52647b6261c..a96e9420ec2a 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -1128,7 +1128,7 @@ static unsigned long __initdata vmalloc_size = 240 * SZ_1M; > /* > * vmalloc=size forces the vmalloc area to be exactly 'size' > * bytes. This can be used to increase (or decrease) the vmalloc > - * area - the default is 240m. > + * area - the default is 240MiB. > */ > static int __init early_vmalloc(char *arg) > { > @@ -1137,14 +1137,14 @@ static int __init early_vmalloc(char *arg) > > if (vmalloc_reserve < SZ_16M) { > vmalloc_reserve = SZ_16M; > - pr_warn("vmalloc area too small, limiting to %luMB\n", > + pr_warn("vmalloc area is too small, limiting to %luMiB\n", > vmalloc_reserve >> 20); > } > > vmalloc_max = VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET); > if (vmalloc_reserve > vmalloc_max) { > vmalloc_reserve = vmalloc_max; > - pr_warn("vmalloc area is too big, limiting to %luMB\n", > + pr_warn("vmalloc area is too big, limiting to %luMiB\n", > vmalloc_reserve >> 20); > } > > -- > 2.20.1 >
diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index d52647b6261c..a96e9420ec2a 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1128,7 +1128,7 @@ static unsigned long __initdata vmalloc_size = 240 * SZ_1M; /* * vmalloc=size forces the vmalloc area to be exactly 'size' * bytes. This can be used to increase (or decrease) the vmalloc - * area - the default is 240m. + * area - the default is 240MiB. */ static int __init early_vmalloc(char *arg) { @@ -1137,14 +1137,14 @@ static int __init early_vmalloc(char *arg) if (vmalloc_reserve < SZ_16M) { vmalloc_reserve = SZ_16M; - pr_warn("vmalloc area too small, limiting to %luMB\n", + pr_warn("vmalloc area is too small, limiting to %luMiB\n", vmalloc_reserve >> 20); } vmalloc_max = VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET); if (vmalloc_reserve > vmalloc_max) { vmalloc_reserve = vmalloc_max; - pr_warn("vmalloc area is too big, limiting to %luMB\n", + pr_warn("vmalloc area is too big, limiting to %luMiB\n", vmalloc_reserve >> 20); }
Rather than using "m" (which is the unit of metres, or milli), and "MB" in the printk statements, use MiB to make it clear that we are talking about the power-of-2 megabytes, aka mebibytes. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- arch/arm/mm/mmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)