From patchwork Mon Apr 11 09:46:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 12808817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BAFDC4332F for ; Mon, 11 Apr 2022 09:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:MIME-Version:Subject:Cc :To:From:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nz9hw4cvhGv0sqlPgg21Q4j21opxDw9f3TAqkCbxxgM=; b=3+AbzbwqixRcsS Siq3ZLnpVBb734t3D5I9L8TObwwo3MhYJlKula14Zet38lsDXqJuyOc2uWTani1f2JFH+ya3wRdmT c39KkmN+XuU2yhKYi0vgH42YbUC+qDxtziSkWC6VGcRXpzb16m2w00MbBYOHWj7p1eRggQw5Arzxr Hh4oQqYo3TmJaNOQQIpa8Mq//KUAuIBvh4ZjJBerGeMZvGs24zEgOWlgTVIBRAf7Il+lbCnEx6Roa NhNaQ/9f4fTyYoktsG+O0V56vLsr2LJsmZsWaw2dtt49P63AtywxdN0IF+LpfggDsct235+0F3sAM lxsAWgIv2fnNbFCO18kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndqdS-00812D-Mv; Mon, 11 Apr 2022 09:47:02 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndqcj-0080eG-1s; Mon, 11 Apr 2022 09:46:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/QFgek31WZKKhHIeYB7HtM9AIlDa5tiHe5pdziNT4u0=; b=x7pB4/9Cxkj1cGo9pmbgIMg4E8 GvddEiWDNj8tQqDYAVRaDCSGU5s1pSE2GeFnbsL1pZ3tZdzO8DYQ1HINlJ5GFMngYniY7KLJMdRKN pOGXGmEQzZq+9bhVHCJt8IBC07JZ1Axw8o20dp92SPUNDNpOM86Vf5BlWmjk3IxdiXpoFTGHF2flI BS7jpt6r4gsNaJ/H+ZcwgQzjSY2wvTBlfd/+ql+K5kd/WO/V3j1uXPow/DYyTcV/6rHz1RxjLLCXt wgMSHyfYBSwCLdjb8c5D7cinYKvsIeyW30/2jGlr6rxXtqyzd1UnucIqndQCZIhzI5wS3o5gHqtY2 BZ4MZsYg==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:52856 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ndqce-0000Gq-W0; Mon, 11 Apr 2022 10:46:12 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ndqce-0055Qv-3L; Mon, 11 Apr 2022 10:46:12 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Landen Chao , DENG Qingfang , Sean Wang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net-next v2 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed() MIME-Version: 1.0 MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 11 Apr 2022 10:46:12 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_024617_143894_046CA9B4 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that we have a better method to select SFP interface modes, we no longer need to use phylink_helper_basex_speed() in a driver's validation function. Tested-by: Marek Behún Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/mt7530.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 4fdd75e88b1b..de9cfd20ccbf 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2946,11 +2946,6 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port, linkmode_and(supported, supported, mask); linkmode_and(state->advertising, state->advertising, mask); - - /* We can only operate at 2500BaseX or 1000BaseX. If requested - * to advertise both, only report advertising at 2500BaseX. - */ - phylink_helper_basex_speed(state); } static int