| Message ID | E1r0JM0-00CTy7-NL@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Initial cleanups for vCPU hotplug | expand |
On 11/7/23 20:30, Russell King (Oracle) wrote: > Since the x86 version of arch_unregister_cpu() is the same as the weak > version, drop the x86 specific version. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > Changes since RFC v3: > * Adapt to removal of EXPORT_SYMBOL()s > --- > arch/x86/kernel/topology.c | 5 ----- > 1 file changed, 5 deletions(-) > PATCH[16/22] can be folded to PATCH[15/22] since arch_unregister_cpu() was just added in PATCH[15/22]. Anyway, the changes make sense to me. Reviewed-by: Gavin Shan <gshan@redhat.com> > diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c > index c2ed3145a93b..211863cb5b81 100644 > --- a/arch/x86/kernel/topology.c > +++ b/arch/x86/kernel/topology.c > @@ -43,9 +43,4 @@ int arch_register_cpu(int cpu) > c->hotpluggable = cpu > 0; > return register_cpu(c, cpu); > } > - > -void arch_unregister_cpu(int num) > -{ > - unregister_cpu(&per_cpu(cpu_devices, num)); > -} > #endif /* CONFIG_HOTPLUG_CPU */
On Tue, 07 Nov 2023 10:30:40 +0000 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > Since the x86 version of arch_unregister_cpu() is the same as the weak > version, drop the x86 specific version. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index c2ed3145a93b..211863cb5b81 100644 --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -43,9 +43,4 @@ int arch_register_cpu(int cpu) c->hotpluggable = cpu > 0; return register_cpu(c, cpu); } - -void arch_unregister_cpu(int num) -{ - unregister_cpu(&per_cpu(cpu_devices, num)); -} #endif /* CONFIG_HOTPLUG_CPU */
Since the x86 version of arch_unregister_cpu() is the same as the weak version, drop the x86 specific version. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- Changes since RFC v3: * Adapt to removal of EXPORT_SYMBOL()s --- arch/x86/kernel/topology.c | 5 ----- 1 file changed, 5 deletions(-)