From patchwork Thu Jun 13 10:36:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13696589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C162C27C75 for ; Thu, 13 Jun 2024 10:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:Content-Type :Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s2lHzukmb8hrOXev5/PBGl9GhDsxZO3hlbsDi9vMyB8=; b=Jd7gPNf/kyYAGaKykXy/f4wDN0 GMh2H6ePtgqlcpA1mc7ZSj6P4eFo0zDWBUNFZwlD07HmAF2GVT+IadDSIvs9ptNNfjji+NhwIDsqM NmGQ/OvmHZ/mQmtKF9dzpJRQRp997b9qVEqsaGM/YlWtzxTXKMEqRVupTWAS0e8spmSuK0HQE/EgO L0M+VsIk/NXETvVYsisWifXnGK99IQQ9hqysYMTBDJxf+lw1G9iD0rHE+BddlVv1hqey3ISn/oC21 nBTTl8mHEi5xmeRIxPa24rVNTtNW/oLS8BX2Q7oeEV8QvQIlpLSxtvwF6Cnnebzw+h+rUQWK0uvc3 I+5E8ESw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHhpA-0000000GArB-32Yi; Thu, 13 Jun 2024 10:36:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHhox-0000000GAgw-03Fl for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 10:36:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s2lHzukmb8hrOXev5/PBGl9GhDsxZO3hlbsDi9vMyB8=; b=fMu5Ks35qQ3Pd/+tM00D+kUzDw s6mo13JtMV3j8Zm39QY/hKj8WjIpZzMrGZtjCVzTrXWrKwhX4IYbn4Y/h/PwhTsS6439aR8ofpS9Q uitIPDP/7XyanSW7Zrug2jPrqWbZICghLro50NM3oG3BJ4pTrjZaSYhioi60cVQIFhKtG+kz3LdSY 5munwv1TQulFvU45tmlbWjxyCCtI8YM8TW4M5nkrFxYUS0QQZoGuPY68Jk4OGOxGmOZK5ZhKwiONM smEL/SlUv6B7PgVC81niHj+imhHjfIC4EC+V6lNW3F2tyi0sRzS0UmJckQIqiuwhJmfDhuN+dnnEa kxJIWOtw==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:45528 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sHhof-00066I-1r; Thu, 13 Jun 2024 11:36:25 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sHhoh-00FetT-3S; Thu, 13 Jun 2024 11:36:27 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Serge Semin Cc: Alexandre Torgue , Andrew Halaney , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Romain Gantois Subject: [PATCH net-next v2 5/5] net: stmmac: clean up stmmac_mac_select_pcs() MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Thu, 13 Jun 2024 11:36:27 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_033643_136635_F212FD00 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since all platform providers of PCS now populate the select_pcs() method, there is no need for the common code to look at priv->hw->phylink_pcs, so remove it. Reviewed-by: Romain Gantois Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index e9e2a95c91a3..5ddbb0d44373 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -957,7 +957,7 @@ static struct phylink_pcs *stmmac_mac_select_pcs(struct phylink_config *config, return pcs; } - return priv->hw->phylink_pcs; + return NULL; } static void stmmac_mac_config(struct phylink_config *config, unsigned int mode,