From patchwork Thu Apr 7 00:09:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 12804259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A017C433EF for ; Thu, 7 Apr 2022 00:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zTMqgGZsmTYYB5cYzVGvjswrvFjoVs/vfAWfpem+OIY=; b=hXLFqbs2sSVtaX mSuDCsCNxEZ36rLClJuAlpSo1xWzXIvJKJgKlmEdeDyQpOJhya6TzuTrJq1+jJKzQKgns8zlNGsEZ 2Nc5Km4DxSyHjQJJYq5zWsFkukdoCrtlZS+LFxUwvvDhsOOva8lz/wzDIXruyd1MpAPmEhyTgowqH hjD+7O3KtkNGm81g2Zfj22l/b+S+lLjSyK24Xr5g/XKjtHg6xbrzo2NT0uidUgIsy/AkUcRZcB6dU xSYlPf1rwLeMu3FijfsGZR5fQTKqaxKJys4vC4AYAvOoELU6vS1nNk1CEVLOJeRF+tE8+wjEH0We3 i9lGrD+gz1huXgDiMZjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncFiL-008NOS-6X; Thu, 07 Apr 2022 00:09:29 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncFiI-008NNv-Fn for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 00:09:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649290166; x=1680826166; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Hby0y0Ir6ck0vQWnbhhrqq80CGHoZxpgFD5r476HwgY=; b=H4UaCxyb/vqBdJoh1dpDkuDUn1tj5AtBhsqhG89fa9yS8pawW2UEZruf +iz1az1n2limYPyzPVvLGCtJov1FhBrr0fF/Muos7+pZJssduA8irPA8L inaNFowkbZuCGsFj0xRHkQ7rHVDo+Itxflgug3GP79ZlFDKtclGFmQBrr frgyzr54HRTBE8g+QxpDZBpm1hJattCRsMMmx/Qh7kbmKK+9mVGAk5roy oF2zQQeSeSjrbLRJ3JAKJTQjAyQvgdcArKWVtgJKfKcjrHtE2obED1nCz nTMvwGGUV0+PP1Aa+xSZTF9SuMjkLpWxcrkquoX+eMLqSrXIO4SS1s2L2 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="258780012" X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="258780012" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 17:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="588586327" Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2022 17:09:22 -0700 Received: from kbuild by a44fdfb70b94 with local (Exim 4.95) (envelope-from ) id 1ncFiE-0004sV-1U; Thu, 07 Apr 2022 00:09:22 +0000 Date: Thu, 7 Apr 2022 08:09:14 +0800 From: kernel test robot To: Linus Walleij Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] Input: fix odd_ptr_err.cocci warnings Message-ID: References: <202204070801.hNvu3cEu-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202204070801.hNvu3cEu-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_170926_582932_FB4CB423 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: kernel test robot drivers/input/misc/isa1200.c:327:5-11: inconsistent IS_ERR and PTR_ERR on line 328. drivers/input/misc/isa1200.c:332:5-11: inconsistent IS_ERR and PTR_ERR on line 333. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git ux500-janice-v5.18-rc1 head: 7d27ddbe075c07508ab045a63d23aeca798514ee commit: 0baaba96c1a1116b9fc698a263657cb9b6ab8198 [18/21] Input: isa1200 - new driver for Immersion ISA1200 :::::: branch date: 27 hours ago :::::: commit date: 29 hours ago drivers/input/misc/isa1200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/input/misc/isa1200.c +++ b/drivers/input/misc/isa1200.c @@ -325,12 +325,12 @@ static int isa1200_probe(struct i2c_clie isa->hen = devm_gpiod_get(dev, "hen", GPIOD_OUT_LOW); if (IS_ERR(isa->hen)) { - ret = PTR_ERR(isa->map); + ret = PTR_ERR(isa->hen); return dev_err_probe(dev, ret, "failed to get HEN GPIO\n"); } isa->len = devm_gpiod_get(dev, "len", GPIOD_OUT_LOW); if (IS_ERR(isa->hen)) { - ret = PTR_ERR(isa->map); + ret = PTR_ERR(isa->hen); return dev_err_probe(dev, ret, "failed to get LEN GPIO\n"); }