diff mbox

[3/3] ARM: Kirkwood: add DT boards to defconfig

Message ID a0e20df2d8ad6dbcf66fa9a14482a305c4a109fe.1344651264.git.jason@lakedaemon.net (mailing list archive)
State New, archived
Headers show

Commit Message

Jason Cooper Aug. 11, 2012, 2:39 a.m. UTC
Also, disable DEBUG_KERNEL, enable SERIAL_OF_PLATFORM, and enable EMBEDDED

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
 arch/arm/configs/kirkwood_defconfig |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

Comments

Andrew Lunn Aug. 11, 2012, 6:21 a.m. UTC | #1
On Sat, Aug 11, 2012 at 02:39:47AM +0000, Jason Cooper wrote:
> Also, disable DEBUG_KERNEL, enable SERIAL_OF_PLATFORM, and enable EMBEDDED

Hi Jason

Why disable DEBUG_KERNEL. Most of the other defconfig files have it
enabled.



> 
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
>  arch/arm/configs/kirkwood_defconfig |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> index 5a494a3..0865d2e 100644
> --- a/arch/arm/configs/kirkwood_defconfig
> +++ b/arch/arm/configs/kirkwood_defconfig
> @@ -3,6 +3,9 @@ CONFIG_SYSVIPC=y
>  CONFIG_NO_HZ=y
>  CONFIG_HIGH_RES_TIMERS=y
>  CONFIG_LOG_BUF_SHIFT=19
> +CONFIG_NAMESPACES=y
> +CONFIG_BLK_DEV_INITRD=y

Do we need these two as well? Namespaces seems a bit unusual for a
tiny embedded device.

     Andrew
Jason Cooper Aug. 11, 2012, 4:47 p.m. UTC | #2
On Sat, Aug 11, 2012 at 08:21:11AM +0200, Andrew Lunn wrote:
> On Sat, Aug 11, 2012 at 02:39:47AM +0000, Jason Cooper wrote:
> > Also, disable DEBUG_KERNEL, enable SERIAL_OF_PLATFORM, and enable EMBEDDED
> 
> Why disable DEBUG_KERNEL. Most of the other defconfig files have it
> enabled.

I usually get burned on desktop kernels with ~90MB initrds filling up my
/boot partition, so I'm in the habit of disabling it.  It appears the
convention is to enable it for defconfigs (86 of 129 in v3.6-rc1), so
I'll re-enable it.

> > 
> > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> > ---
> >  arch/arm/configs/kirkwood_defconfig |   12 +++++++++++-
> >  1 files changed, 11 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> > index 5a494a3..0865d2e 100644
> > --- a/arch/arm/configs/kirkwood_defconfig
> > +++ b/arch/arm/configs/kirkwood_defconfig
> > @@ -3,6 +3,9 @@ CONFIG_SYSVIPC=y
> >  CONFIG_NO_HZ=y
> >  CONFIG_HIGH_RES_TIMERS=y
> >  CONFIG_LOG_BUF_SHIFT=19
> > +CONFIG_NAMESPACES=y
> > +CONFIG_BLK_DEV_INITRD=y
> 
> Do we need these two as well? Namespaces seems a bit unusual for a
> tiny embedded device.

initrd is another thing I do out of habit.  I tend to use an initrd that
drops to a shell for testing.

I'll disable both.  Time for v2.

thx,

Jason.
Andrew Lunn Aug. 11, 2012, 10:06 p.m. UTC | #3
On Sat, Aug 11, 2012 at 02:39:47AM +0000, Jason Cooper wrote:
> Also, disable DEBUG_KERNEL, enable SERIAL_OF_PLATFORM, and enable EMBEDDED
> 
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
>  arch/arm/configs/kirkwood_defconfig |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> index 5a494a3..0865d2e 100644
> --- a/arch/arm/configs/kirkwood_defconfig
> +++ b/arch/arm/configs/kirkwood_defconfig
> @@ -3,6 +3,9 @@ CONFIG_SYSVIPC=y
>  CONFIG_NO_HZ=y
>  CONFIG_HIGH_RES_TIMERS=y
>  CONFIG_LOG_BUF_SHIFT=19
> +CONFIG_NAMESPACES=y
> +CONFIG_BLK_DEV_INITRD=y
> +CONFIG_EMBEDDED=y
>  CONFIG_PROFILING=y
>  CONFIG_OPROFILE=y
>  CONFIG_KPROBES=y
> @@ -17,6 +20,13 @@ CONFIG_MACH_MV88F6281GTW_GE=y
>  CONFIG_MACH_SHEEVAPLUG=y
>  CONFIG_MACH_ESATA_SHEEVAPLUG=y
>  CONFIG_MACH_GURUPLUG=y
> +CONFIG_MACH_DREAMPLUG_DT=y
> +CONFIG_MACH_ICONNECT_DT=y
> +CONFIG_MACH_DLINK_KIRKWOOD_DT=y
> +CONFIG_MACH_IB62X0_DT=y
> +CONFIG_MACH_TS219_DT=y
> +CONFIG_MACH_GOFLEXNET_DT=y
> +CONFIG_MACH_LSXL_DT=y

Hi Jason

Depending on the order things get merged, it would be good if
Sebastians' and Ians' new boards are also enabled.

	    Andrew
Jason Cooper Aug. 11, 2012, 11:18 p.m. UTC | #4
On Sun, Aug 12, 2012 at 12:06:45AM +0200, Andrew Lunn wrote:
> On Sat, Aug 11, 2012 at 02:39:47AM +0000, Jason Cooper wrote:
> > Also, disable DEBUG_KERNEL, enable SERIAL_OF_PLATFORM, and enable EMBEDDED
> > 
> > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> > ---
> >  arch/arm/configs/kirkwood_defconfig |   12 +++++++++++-
> >  1 files changed, 11 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> > index 5a494a3..0865d2e 100644
> > --- a/arch/arm/configs/kirkwood_defconfig
> > +++ b/arch/arm/configs/kirkwood_defconfig
> > @@ -3,6 +3,9 @@ CONFIG_SYSVIPC=y
> >  CONFIG_NO_HZ=y
> >  CONFIG_HIGH_RES_TIMERS=y
> >  CONFIG_LOG_BUF_SHIFT=19
> > +CONFIG_NAMESPACES=y
> > +CONFIG_BLK_DEV_INITRD=y
> > +CONFIG_EMBEDDED=y
> >  CONFIG_PROFILING=y
> >  CONFIG_OPROFILE=y
> >  CONFIG_KPROBES=y
> > @@ -17,6 +20,13 @@ CONFIG_MACH_MV88F6281GTW_GE=y
> >  CONFIG_MACH_SHEEVAPLUG=y
> >  CONFIG_MACH_ESATA_SHEEVAPLUG=y
> >  CONFIG_MACH_GURUPLUG=y
> > +CONFIG_MACH_DREAMPLUG_DT=y
> > +CONFIG_MACH_ICONNECT_DT=y
> > +CONFIG_MACH_DLINK_KIRKWOOD_DT=y
> > +CONFIG_MACH_IB62X0_DT=y
> > +CONFIG_MACH_TS219_DT=y
> > +CONFIG_MACH_GOFLEXNET_DT=y
> > +CONFIG_MACH_LSXL_DT=y
> 
> Depending on the order things get merged, it would be good if
> Sebastians' and Ians' new boards are also enabled.

Agreed, I'll hold off on this until we get theirs upstream, then I'll
push v3 including their boards.

In the future, new boards should include a change to the appropriate
defconfig to enable building them.  I'll make sure to mention it on
anything new coming in.

thx,

Jason.
diff mbox

Patch

diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
index 5a494a3..0865d2e 100644
--- a/arch/arm/configs/kirkwood_defconfig
+++ b/arch/arm/configs/kirkwood_defconfig
@@ -3,6 +3,9 @@  CONFIG_SYSVIPC=y
 CONFIG_NO_HZ=y
 CONFIG_HIGH_RES_TIMERS=y
 CONFIG_LOG_BUF_SHIFT=19
+CONFIG_NAMESPACES=y
+CONFIG_BLK_DEV_INITRD=y
+CONFIG_EMBEDDED=y
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
 CONFIG_KPROBES=y
@@ -17,6 +20,13 @@  CONFIG_MACH_MV88F6281GTW_GE=y
 CONFIG_MACH_SHEEVAPLUG=y
 CONFIG_MACH_ESATA_SHEEVAPLUG=y
 CONFIG_MACH_GURUPLUG=y
+CONFIG_MACH_DREAMPLUG_DT=y
+CONFIG_MACH_ICONNECT_DT=y
+CONFIG_MACH_DLINK_KIRKWOOD_DT=y
+CONFIG_MACH_IB62X0_DT=y
+CONFIG_MACH_TS219_DT=y
+CONFIG_MACH_GOFLEXNET_DT=y
+CONFIG_MACH_LSXL_DT=y
 CONFIG_MACH_TS219=y
 CONFIG_MACH_TS41X=y
 CONFIG_MACH_DOCKSTAR=y
@@ -89,6 +99,7 @@  CONFIG_LEGACY_PTY_COUNT=16
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_RUNTIME_UARTS=2
+CONFIG_SERIAL_OF_PLATFORM=y
 # CONFIG_HW_RANDOM is not set
 CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
@@ -157,7 +168,6 @@  CONFIG_NLS_ISO8859_2=y
 CONFIG_NLS_UTF8=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
-CONFIG_DEBUG_KERNEL=y
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_DEBUG_PREEMPT is not set
 CONFIG_DEBUG_INFO=y