From patchwork Mon Oct 16 20:18:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10009781 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CA72D60235 for ; Mon, 16 Oct 2017 20:20:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6C65286E3 for ; Mon, 16 Oct 2017 20:20:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A75A9286F4; Mon, 16 Oct 2017 20:20:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1BA81286E0 for ; Mon, 16 Oct 2017 20:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-ID:Subject: From:To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Wg3M8yaBl1cJu5HHLFl9Yo+0Xvj5gggYCLl7WfbQhlM=; b=U6V6vakcsiByVP bc2CpWPbLs2AtfhVesoO3N7J+tpppUFOf4+tSBcD2AI/JVDKFmoD+FLMRzpriayu2Lu1ECVxIzalm /qugbVaUgCYChYqIrtQuiWAXikFeJJLLkI2DdO6bcElXr02GeT/VuChtPQrjD0CvxRJ6dW4VEOu2K rabDbCdwv5PAFRou8/pl1O6IyqR84Nhm9vRANHFSlf+PbxNdPMjWRdskitJfepH9c47XdYnfEZWu3 5cX2c78FPhI4OW99BxIPMWzFLfS/9o2s68o3IYnHWXv5w3mSvXTQ1cKUNK/FriLNqmAqN5zpKgnc9 3r08bq0p8O82aWDK0k1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e4BrR-0005SZ-Ft; Mon, 16 Oct 2017 20:19:41 +0000 Received: from mout.web.de ([217.72.192.78]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e4BrN-0005QZ-Et for linux-arm-kernel@lists.infradead.org; Mon, 16 Oct 2017 20:19:39 +0000 Received: from [192.168.1.2] ([78.49.107.148]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lj2Dy-1dWmqL3c0E-00dFQF; Mon, 16 Oct 2017 22:19:00 +0200 To: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Michal Simek , Nava kishore Manne , Rob Herring , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= From: SF Markus Elfring Subject: [PATCH] xilinx_hwicap: Improve a size determination in hwicap_setup() Message-ID: Date: Mon, 16 Oct 2017 22:18:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:KIPaBEREtCSNHySFAFDeNnscM9wIP59OBqpXiDSvCin8CMGT7py WsOlIfC86mGEtUOuxlLpwpaio/6SqeTo9uKZg6mJpqQ9+d2zYewT5LMDGYUwc33ANhNPKmQ dT7ANDrFWGPiaM5tADrHJZhdsGg2hpB++9LlNA0tHZAhtx8IughQdVEFiDgKIBqFd5FYMC8 SLdid+wxS3VoD9XY9KYsw== X-UI-Out-Filterresults: notjunk:1; V01:K0:tbm5B+WTshc=:B0zwoJi+PQyUE9L5PWV/V1 R1dBhum/omw6vaAQv6awiIktc5yBe70Q/LqiCW5LaiLfyHMFzIflTI6/BaWnC/uMkVuf74/aF GfhWyzMl5YpOgYGPg6LWgLrNKrlMxl7kZ2/p4rxSIIMmIzy1eUG0aMiCHGer14TXfb5oqFaew xhYNEQjzF0gSvnCCzSvC2gbvADzd/dc2n1cZmJOrlhOk/HBmZZIH2NrFuhTu1NdFFB+WsPn3h s8ctoo0pzQfmjmsFr//QDAwaJ08r7TDtPlB4oRmSmzp5Tht+VyJcJ/gE3JYeI7SLAG5v0sAzF e46OvIslAzFGqo2Fwny58o1YBRIMU9h4htcQAeMHt4Yfb6lvtP7YHbRKRIj9V+9qzT1L7XHA2 4sIEEADv3E9WZ4wlf0FvJsPoJeYOX1/5qK6WFbRufH3uhKX6vP6ep0YkcnTWkmdPZPnItQaOQ ZMmgX9GuRi3KA3xPg0DSLpVzXDwG7PwSetcx87BIfdAxKIjS9GRduIcf/vkFExsdAbP2Y23ij 5WCclKgEiWA3bwfgs4W/GNlfnGPyS0nWrSz66MrEuMuJrEldLmuT/FAtmNn/3MVKidQklZNRS nAJ+OPxJQT9BecxGkV7dfft/8ts6cj/z5D/7/AZpUIdn0dkZuLFiLW5XFaHI2vPi0ZYKuGsuv 6/Esu+9vltUysp/ZRe/gcnOTfiW1OAjbstcks2+lf9HrxPV/EryjyhoIUeN3NpauYIMOhGSy8 P6G2RAwjoIggcjBfviJrsFUh14yEE1VmlUWjZDAWZ+URWl7NYyExsHVsoTSU+YKrH8sObuR7e BFqq9BjvWa0TXc3biTWedJPVGPdm+NnhXwxoDxXKrwb78msVWA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171016_131937_834900_B5C237F9 X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Mon, 16 Oct 2017 22:10:32 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 067396bedf22..2ab9df5a60bd 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -634,7 +634,7 @@ static int hwicap_setup(struct device *dev, int id, devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR + id); - drvdata = kzalloc(sizeof(struct hwicap_drvdata), GFP_KERNEL); + drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL); if (!drvdata) { retval = -ENOMEM; goto failed0;