From patchwork Fri Nov 17 20:20:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1247601D3 for ; Fri, 17 Nov 2017 20:20:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2DCE2ADA0 for ; Fri, 17 Nov 2017 20:20:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 975842ADA7; Fri, 17 Nov 2017 20:20:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 309632ADA0 for ; Fri, 17 Nov 2017 20:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Ey8SJHQS/glYoXgK6y0a+9UPE+frWnXzi0hAMIbOGdg=; b=tbw Tbb/Nmvs8R/J4Yrs4oHTzx7y/J9PMrdb90AUVwTOx9ZBJ7y53okqbw2CI1ib3VneaKAvhikvEmdRA YuejdZBFodeNnoLFkCyYoru868hzFf0l26AU1UlJI0f76bwmJAKk3cDLobxEOH+ACf3U1mwhJb+0m P0xbcDoiK9B4V6gh5BZJaPvBbW7ceK6u/JH/9l4ctLzYjUjwpfpQrqXelbAp4LDV3wUDsinBUqZD3 Qkij8UL/Tulf/HU6qh0MAWtyjIys+5mTlYIEOofdCg3mDW1gR/wO3LQRzXYhZ9Fx1Gu5Wim9Tno3y a2miigX+jBa0Ofj7Bw+JBw1X77KhgEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFn7v-0001od-TQ; Fri, 17 Nov 2017 20:20:39 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFn7s-0001mJ-9m for linux-arm-kernel@lists.infradead.org; Fri, 17 Nov 2017 20:20:37 +0000 Received: by mail-pg0-x242.google.com with SMTP id 70so2723325pgf.6 for ; Fri, 17 Nov 2017 12:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HJPjcLNxExWQPbIU2n8QqxCEKnT+d2Ym6b8x9TrWrl0=; b=UFycR/Sr6bad0prdAUjL9soxMAfe6lIUVSkLTmQIE5iWy9WBdUBhgBEPcBa4+0rWll j9ER7s5ERv7AVxbOIvO0FJlBJLzpvcWZROuYhv4R0Vs3XqCHwn/yvESSoVVQ8NLG7YU8 fYQdHA0lnF9fIeazE7UyIiezu81tbL1kgDIAul9Hod6+IXy4OyFauUnETgguXUC4Tk2S GacSsCYP/ylALlH025co+RhMlreAzCeu7PciVHckbMBcGdeT3Dq758Ye6gwBKsyAmCNQ idJgQRrvB7q1R+rGiWs+R4aACs1oQQvhitAD9eb+OzssvQ1ZADhvuS+1y2ctchtT1Fh7 gcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HJPjcLNxExWQPbIU2n8QqxCEKnT+d2Ym6b8x9TrWrl0=; b=naLwGDcasmk1fmp33ZmBX9MuoHuATKXgx6YDgWl5/wZ8uT4enCEDUDmCY/aj/bHvYD 49PrYiO6ZDqpvcBkk5q/JZ90bapHTZbxXmM3M4u/RjMZ67HADkQ8UVSg0QpDRepiLCvU 4Nge6E/MVrd2oZHJOgwBD423rWqi094vPAi+6/lV0WFc8VBM0Png1tLHf/tP4ltKj1uA tBx/0i5To+vrEttyJ9h3iW4Jv+r+wO6pnJaE/i4R/sc0LUuE1q/124DYmYtChTRlTZy4 omUc61uNKVJ7+bcVx8eblsgLmCGuf+dOxo7BW4w6N33fuARAqD4/u8Dnl0hJdpoklVmb HIkg== X-Gm-Message-State: AJaThX6/O8hN7XAGMkNfu54TaAVkHaEITN3Ui0Notz4Gp4cA7km1rlJD GIecjo83Da4wBnZc13baNIY= X-Google-Smtp-Source: AGs4zMYI3JGbqUZH7SR2DgNQ1JrvaUtueS/tv17ghAuEekW9tyqtXdFacfoRvBJJ7+lup6IV9grH0g== X-Received: by 10.99.122.73 with SMTP id j9mr6160920pgn.154.1510950015256; Fri, 17 Nov 2017 12:20:15 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id i3sm7674715pgc.88.2017.11.17.12.20.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 12:20:13 -0800 (PST) From: Arvind Yadav To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com Subject: [PATCH 1/10 v2] Input: ep93xx_keypad: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 01:50:01 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_122036_406895_3CF3B6FA X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2c: Return keypad->irq insted of -ENXIO. drivers/input/keyboard/ep93xx_keypad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c index f77b295..01788a7 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev) } keypad->irq = platform_get_irq(pdev, 0); - if (!keypad->irq) { - err = -ENXIO; + if (keypad->irq < 0) { + err = keypad->irq; goto failed_free; }