From patchwork Fri Dec 15 13:59:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13494502 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6547AC35274 for ; Fri, 15 Dec 2023 14:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C8kS2xaJBucq6G1dbpud4ppRstOtJJtbaceD6vo1swo=; b=wtvkR3OcQE6dnt hYUK+dOq4tTtALbxhkSXQ5W/qSD1M1BPnH3ptWTGUraH78ccRbI4+lLsxNb9gF7oq+/lbYCYU9HnW bKddTNK+jmrSL7eesZ1ND3SWGi7i7tQf9bKsawqstgK0+kuCZvvibN0YhnNQxNxQX5CUcVlUN4yYX t8MrC+By6ZYSTI2XAat1OLRj0mOjWmYtaLp8btxEQKF/1yaBc8yGgFGnXHg2WTyPmyNn/ES82G+FU Gtl/gYWTqYAR3j9bF/qs7Mwf4sFOiJMsGU6cliX03jw6aBXj+yZmhUjBkl/ZzlHb/dBEhQO5SAnw7 252DrlUSmA0+lkUmatsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rE8jF-003Sv2-0L; Fri, 15 Dec 2023 13:59:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rE8iz-003Skd-01 for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 13:59:35 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8ix-0002mR-BL; Fri, 15 Dec 2023 14:59:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8iw-00G2Zp-UK; Fri, 15 Dec 2023 14:59:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iw-003cCc-Kk; Fri, 15 Dec 2023 14:59:30 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/18] perf: arm_spe: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:10 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ebvrrVyODNmxG3JvaFcjW9M/wrd0jxp2bmDDzLkJNiU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFuwX1T9I98FsOZp/j5NoPrWESK2E3mBg3LWt VCaiOeyYiqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbsAAKCRCPgPtYfRL+ TgtzCACm2pQyhNJ/AJgC3ETsfXRz6oWzGYTxy2234b+nUURm2k4Z5MDNXqpcVrKfleWHD6qZnOP lQLYvUeaUjudGxEGvwadRqepqSeaV54gsAtNQhtSobFMoeJ4pXVxaDuB0N1krBYmqz87ykPvhxg NVqhwz+ZHZJTAmINKAd5gDhNRqratyN9uTiOTDF/dXuD304nabaTRih3ZSycOPQH8oT6eVkq7DQ XocFHOJ7jvs3CK0yv9kp3hQDqezmVM9YpymgUM4OLmi1WFxkVHEAELS8JsKIZQcWRuW8e65zfp/ DgW8qqlGV1xUqK5F6VpYEhF5nGCCmwNl6lwcGA6uO5FNQUwd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_055933_052718_9655629F X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/arm_spe_pmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index b622d75d8c9e..35f0de03416f 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -1263,14 +1263,13 @@ static int arm_spe_pmu_device_probe(struct platform_device *pdev) return ret; } -static int arm_spe_pmu_device_remove(struct platform_device *pdev) +static void arm_spe_pmu_device_remove(struct platform_device *pdev) { struct arm_spe_pmu *spe_pmu = platform_get_drvdata(pdev); arm_spe_pmu_perf_destroy(spe_pmu); arm_spe_pmu_dev_teardown(spe_pmu); free_percpu(spe_pmu->handle); - return 0; } static struct platform_driver arm_spe_pmu_driver = { @@ -1281,7 +1280,7 @@ static struct platform_driver arm_spe_pmu_driver = { .suppress_bind_attrs = true, }, .probe = arm_spe_pmu_device_probe, - .remove = arm_spe_pmu_device_remove, + .remove_new = arm_spe_pmu_device_remove, }; static int __init arm_spe_pmu_init(void)