| Message ID | ac58dbed203260f9bb93d7685c8f0e08407e0019.1490987945.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Freitag, den 31.03.2017, 22:25 +0300 schrieb Leonard Crestez: > The pu regulator request will return -EPROBE_DEFER if it has a supply > from PMIC and this supply is not yet registered. This does not represent > an error since the driver will call probe again later, so only print a > warning message in this case. > > Signed-off-by: Irina Tirdea <irina.tirdea@nxp.com> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > --- > arch/arm/mach-imx/gpc.c | 6 +++++- The driver moved places, together with a large rewrite, to drivers/soc/imx/. This issue isn't present in the new driver, so this patch can just be dropped. Regards, Lucas > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c > index 1dc2a34..ce64d11 100644 > --- a/arch/arm/mach-imx/gpc.c > +++ b/arch/arm/mach-imx/gpc.c > @@ -466,7 +466,11 @@ static int imx_gpc_probe(struct platform_device *pdev) > pu_reg = NULL; > if (IS_ERR(pu_reg)) { > ret = PTR_ERR(pu_reg); > - dev_err(&pdev->dev, "failed to get pu regulator: %d\n", ret); > + if (ret == -EPROBE_DEFER) > + dev_dbg(&pdev->dev, "pu regulator not ready, retry\n"); > + else > + dev_err(&pdev->dev, "failed to get pu regulator: %d\n", > + ret); > return ret; > } >
On Tue, 2017-04-04 at 11:46 +0200, Lucas Stach wrote: > Am Freitag, den 31.03.2017, 22:25 +0300 schrieb Leonard Crestez: > > > > The pu regulator request will return -EPROBE_DEFER if it has a supply > > from PMIC and this supply is not yet registered. This does not represent > > an error since the driver will call probe again later, so only print a > > warning message in this case. > > > > Signed-off-by: Irina Tirdea <irina.tirdea@nxp.com> > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > > --- > > arch/arm/mach-imx/gpc.c | 6 +++++- > The driver moved places, together with a large rewrite, to > drivers/soc/imx/. > > This issue isn't present in the new driver, so this patch can just be > dropped. Wait, I'm confused. In what tree did that happen? This patch is against linus's tree as of last week and there is nothing in drivers/soc/imx. I saw patches for a new gpcv2 driver but that seems to be only for imx7. This patch is for imx6. Will that driver also support imx6? Link: https://lkml.org/lkml/2017/3/28/834 -- Regards, Leonard
Am Dienstag, den 04.04.2017, 13:28 +0300 schrieb Leonard Crestez: > On Tue, 2017-04-04 at 11:46 +0200, Lucas Stach wrote: > > Am Freitag, den 31.03.2017, 22:25 +0300 schrieb Leonard Crestez: > > > > > > The pu regulator request will return -EPROBE_DEFER if it has a supply > > > from PMIC and this supply is not yet registered. This does not represent > > > an error since the driver will call probe again later, so only print a > > > warning message in this case. > > > > > > Signed-off-by: Irina Tirdea <irina.tirdea@nxp.com> > > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > > > --- > > > arch/arm/mach-imx/gpc.c | 6 +++++- > > The driver moved places, together with a large rewrite, to > > drivers/soc/imx/. > > > > This issue isn't present in the new driver, so this patch can just be > > dropped. > > Wait, I'm confused. In what tree did that happen? This patch is against > linus's tree as of last week and there is nothing in drivers/soc/imx. > > I saw patches for a new gpcv2 driver but that seems to be only for > imx7. This patch is for imx6. Will that driver also support imx6? Shawns maintainer tree: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=imx/drivers This is what is staged for the next merge window. Regards, Lucas
diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 1dc2a34..ce64d11 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -466,7 +466,11 @@ static int imx_gpc_probe(struct platform_device *pdev) pu_reg = NULL; if (IS_ERR(pu_reg)) { ret = PTR_ERR(pu_reg); - dev_err(&pdev->dev, "failed to get pu regulator: %d\n", ret); + if (ret == -EPROBE_DEFER) + dev_dbg(&pdev->dev, "pu regulator not ready, retry\n"); + else + dev_err(&pdev->dev, "failed to get pu regulator: %d\n", + ret); return ret; }