diff mbox series

[net,1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

Message ID ad52391dba15c5365e197aea54781037a1c223c7.1611198584.git.richardcochran@gmail.com (mailing list archive)
State New, archived
Headers show
Series Remove unneeded PHY time stamping option. | expand

Commit Message

Richard Cochran Jan. 21, 2021, 4:06 a.m. UTC
The mv88e6xxx is a DSA driver, and it implements DSA style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the bogus dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
---
 drivers/net/dsa/mv88e6xxx/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Brandon Streiff Jan. 21, 2021, 7:59 p.m. UTC | #1
On 1/20/2021 10:06 PM, Richard Cochran wrote:
> The mv88e6xxx is a DSA driver, and it implements DSA style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the bogus dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
Ah, I must have thought I needed skb_defer_rx_timestamp in mv88e6xxx,
but instead DSA gained its own timestamp path so mv88e6xxx turned out
to not need that at all, and I never went back and dropped the Kconfig
dependency. Whoops. Yup, I don't think we don't need it here.

Acked-by: Brandon Streiff <brandon.streiff@ni.com>
diff mbox series

Patch

diff --git a/drivers/net/dsa/mv88e6xxx/Kconfig b/drivers/net/dsa/mv88e6xxx/Kconfig
index 51185e4d7d15..b17540926c11 100644
--- a/drivers/net/dsa/mv88e6xxx/Kconfig
+++ b/drivers/net/dsa/mv88e6xxx/Kconfig
@@ -25,7 +25,6 @@  config NET_DSA_MV88E6XXX_PTP
 	default n
 	depends on NET_DSA_MV88E6XXX_GLOBAL2
 	depends on PTP_1588_CLOCK
-	imply NETWORK_PHY_TIMESTAMPING
 	help
 	  Say Y to enable PTP hardware timestamping on Marvell 88E6xxx switch
 	  chips that support it.