From patchwork Thu Mar 14 12:30:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10852715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C01D1390 for ; Thu, 14 Mar 2019 12:30:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4AB52A3E8 for ; Thu, 14 Mar 2019 12:30:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E24D62A407; Thu, 14 Mar 2019 12:30:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6E11F2A3F9 for ; Thu, 14 Mar 2019 12:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mKZJ1IaY7GlXT9kvyDtjHSZohYXBb+bquG+//QQEco4=; b=k6Bm0IRJt8em1G vz5gzK57yI10K0MJtPzxKMEapvfk7zijB6xnE029ZiKgCpiKZf3yQUSaVT8ZJ4WixDou5HvU6zbEj nP1D41ZkKEmvANxiDH3qiVe/i+/GrP+d2x5xJGJHCIkfjhG0vORebf3YQswPiDb8B4jQkr+bM62re gD6LvowM7RS7WBa8hDXM9O6yCq1EBTZK9zZZwKbiYM81R+KeDdFFzG+tGwtGSxFTAYMkTKBa+jLFb i9NuRFp2QoPwndzFk3gupzuhUSltFPpxZiCWUoyeVDAhF7JVw0ii40MvjRx3cOObd63Y6Z9LNBtPo 516hXKcy/8v2efQm7/WQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PVB-00081I-VV; Thu, 14 Mar 2019 12:30:25 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PUu-0006i3-Nz for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 12:30:21 +0000 Received: by mail-pf1-x444.google.com with SMTP id n125so3726559pfn.5 for ; Thu, 14 Mar 2019 05:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wovyItwhuu6up6N9d5xqiEvzR3TkCWii5hwPk2X/3Vc=; b=AfW758lGDfOT0nmEzqbNvKwVxfumX+W8/udGCjXD6F/kVAt+9HW3qbkUb+4xAQrlHH AYvMwh96/N5Ddez9BM8eWr9IZUijPL2TVPQELBcOvUtSlvloVDco3F5xGxa2QYq0B883 /gu79bAOD15xvxV70t0nRKxz+jDfMF2eQ1vFZEOeNFDJKfeY3gU4AJczX4nm5KhQNA84 AaRUnFYStfFVEE78/q4kBNq8j02L5rSWEEkOLkplz8cZqTCd1dzdaCJgP2F+CRSnWXgU OZ/3xcX8RznL7GB8OqRe47m0nLGrdA+7OeRe1cH0d59wujsho13eR1KMNnBCDp/96DsS Tjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wovyItwhuu6up6N9d5xqiEvzR3TkCWii5hwPk2X/3Vc=; b=byVqjIHrvx5lpLgaXXtVWtPrsKe6CAkrsyRxbpNgE9Jvn4YCcbJWRL9CVnDZ/d7l6x zVXUF1UM8gZryv3PlZJKYip+voYaBNlnsslGq40BzbmSlhhcQN1qkWSx45NBpvTxmR4N KymawD8LEXJO/yqUN/p9g8pZUArI9/9xHAPKtn1f/EMASNZRLRFS4M59UDvzD8lsRabI lww7Qzf2sxxDm1vo20ZaNBcCmLiptNrh4xaLGymk6FxBREanzYwtKIQHosJ5xOqCHez5 i+KG7fj1jl/E1oTB41ptMLdfo8HizUhNEUJWRmKTa0ZBPJwh6fhLW3MaqupdkZZINAR5 VH3g== X-Gm-Message-State: APjAAAUgj5dju+wML9Wm5BvsBiIn8bSfQqydIrMliJ18E0OSnAPaklZ5 JyJaTlOIvemCpzIquTY5kIc= X-Google-Smtp-Source: APXvYqzkBFfEOq7My/mjnNtvbYiVspZBPohjmp4JfJkVKzGcZtulSYEO1Yn4cdZul+eFkTi1Vkunww== X-Received: by 2002:a63:124c:: with SMTP id 12mr29049250pgs.86.1552566607946; Thu, 14 Mar 2019 05:30:07 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a4:3974:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id r86sm25075639pfa.82.2019.03.14.05.30.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 05:30:07 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org Subject: [PATCH v10 04/10] gpio: 104-idi-48: Utilize for_each_set_clump8 macro Date: Thu, 14 Mar 2019 21:30:59 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_053009_328957_DAE8D699 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, William Breathitt Gray , linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 37 ++++++++-------------------------- 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c index 88dc6f2449f6..59c571aecf9a 100644 --- a/drivers/gpio/gpio-104-idi-48.c +++ b/drivers/gpio/gpio-104-idi-48.c @@ -93,42 +93,21 @@ static int idi_48_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) { struct idi_48_gpio *const idi48gpio = gpiochip_get_data(chip); - size_t i; + unsigned int offset; + unsigned long gpio_mask; static const size_t ports[] = { 0, 1, 2, 4, 5, 6 }; - const unsigned int gpio_reg_size = 8; - unsigned int bits_offset; - size_t word_index; - unsigned int word_offset; - unsigned long word_mask; - const unsigned long port_mask = GENMASK(gpio_reg_size - 1, 0); + const unsigned int ngpio = ARRAY_SIZE(ports) * 8; + unsigned int port_addr; unsigned long port_state; /* clear bits array to a clean slate */ bitmap_zero(bits, chip->ngpio); - /* get bits are evaluated a gpio port register at a time */ - for (i = 0; i < ARRAY_SIZE(ports); i++) { - /* gpio offset in bits array */ - bits_offset = i * gpio_reg_size; + for_each_set_clump8(offset, gpio_mask, mask, ngpio) { + port_addr = idi48gpio->base + ports[offset / 8]; + port_state = inb(port_addr) & gpio_mask; - /* word index for bits array */ - word_index = BIT_WORD(bits_offset); - - /* gpio offset within current word of bits array */ - word_offset = bits_offset % BITS_PER_LONG; - - /* mask of get bits for current gpio within current word */ - word_mask = mask[word_index] & (port_mask << word_offset); - if (!word_mask) { - /* no get bits in this port so skip to next one */ - continue; - } - - /* read bits from current gpio port */ - port_state = inb(idi48gpio->base + ports[i]); - - /* store acquired bits at respective bits array offset */ - bits[word_index] |= (port_state << word_offset) & word_mask; + bitmap_set_value8(bits, ngpio, port_state, offset); } return 0;