From patchwork Sat Nov 18 10:55:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 92EF860352 for ; Sat, 18 Nov 2017 10:57:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8ABD42A6A8 for ; Sat, 18 Nov 2017 10:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E15F2A7A6; Sat, 18 Nov 2017 10:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 114552A6A8 for ; Sat, 18 Nov 2017 10:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uxiONy9R4SMPKG3CnmKufVj68zzFkmX4A2M9aeMp654=; b=Zw8v5tdrtTU+j1CvpwqLNRfNS1 u9i9EB/MQSI035gjNO+iBz5xQIyExkmtISwxVSzYn5eQ1+8f/kbxEPgwUuE6ve74nNxVB4v2UThcc GVKB2GIsk2VxKia0NqOZ4rxkYy+CRiOt5yiMSTUdj0tLI6dt3QVDNiW8yo8b8G5Lv6+QHdDAE6DWH Z42XsEofBFHxIOz0QjKfeEYR7ZASOBD33MB7juP8CFHB4f4EJ+WC/kBBSdtWQU+Dbw401N//alXaa 1DJkoE5Q6ewkrPrBlueoPl+BRsBftSZs+crIn1nfEphRNNQp6L4LvmnklVtmmRkjR/3tw1ZQU8Elq l3t/ITIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eG0oV-0006xE-8m; Sat, 18 Nov 2017 10:57:31 +0000 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eG0n6-0005Vt-0P for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 10:56:16 +0000 Received: by mail-pg0-x241.google.com with SMTP id u3so3840320pgn.7 for ; Sat, 18 Nov 2017 02:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=tVNJF2IrneaqvIuTLo6rq7ur6y0ZiIqHnnDiMHzSprQ=; b=rbTvRZQa0qQoSziPhCRURyBiDRHJdtfJKt/7TORstU9umuGIlDm1xkWS5ngWLdafOC 4Q0qyQgVkgGGee/EQnhkyjivTZxJiC5hLHL4gHciL/B/Aj3DpSNUCLqpknHTtHKMkN1E /H5HvTsuzR4gqjH9AunQTlRE80dA2lnwaNdSJ37yunOqdSm1Wx58iTnULI2VOcEeH1HK d9nSW3deDwqTUL2g8aYDktky6DpUXk3nqXiuCf4svK/I+Im0g+fPJbTxza0lRaJeM1L2 uu1eCGwQAOFXtfVm5s98Sbl0OxCiIW4Efy9QUfb+2j+nz8jCEU5JvVaTrA0dKXbv8FiE jS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=tVNJF2IrneaqvIuTLo6rq7ur6y0ZiIqHnnDiMHzSprQ=; b=pxRJs7SRAyaFzzD1vhPMpfjqMXtCC9SlT/9sn3LDsqgxD7ZYTRs2F1KOfjkuECYeCx IClvXQVf6816dBObmup03xfrVOJ23IQZokbbBAFonfls9O5K2n6MqbVOO6YQFCaTucPR e7DyMEET/hFyCDKFwgO8yuJX2ZXuexlhxIKq8jSerYBq00mzXsidLHElxVuJD1BiIv9A woPccaJbSgP5yYVsBKH5i9M9Nlc+XmVodYZc2ZxHwfI1YB7zpepII+tjFClFtFpHG0rb oDRSzkGqeNO0SPfK15Xb6FwxJDyflMhg2GEOkGFPUC/SzPAdvPldJQJB/QlIOWev6bUp Cm/Q== X-Gm-Message-State: AJaThX4ZJw9A7+ziEF9LgZXsMS0b2woLNnhzuIvHOMfxpvEMj8lAIhwK RqstPv+7uZ9EsCO8UHf29io= X-Google-Smtp-Source: AGs4zMbG/XHLjOQxFUatrMkjifE/laQD0bmLWRTv+IBVIfEGtDacDSvW9CZPT0coyz69YV4m4z9jGw== X-Received: by 10.101.97.20 with SMTP id z20mr7710240pgu.267.1511002543224; Sat, 18 Nov 2017 02:55:43 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id g7sm12321513pfj.13.2017.11.18.02.55.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 02:55:42 -0800 (PST) From: Arvind Yadav To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net, linux@armlinux.org.uk, lee.jones@linaro.org Subject: [PATCH 05/10 v3] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 16:25:12 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171118_025604_590001_B751DE37 X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : return irq instead of -ENODEV. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/input/misc/cpcap-pwrbutton.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c index 0abef63..3a0626b 100644 --- a/drivers/input/misc/cpcap-pwrbutton.c +++ b/drivers/input/misc/cpcap-pwrbutton.c @@ -57,6 +57,9 @@ static int cpcap_power_button_probe(struct platform_device *pdev) int irq = platform_get_irq(pdev, 0); int err; + if (irq <= 0) + return irq; + button = devm_kmalloc(&pdev->dev, sizeof(*button), GFP_KERNEL); if (!button) return -ENOMEM;