From patchwork Thu Jun 13 12:47:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13696750 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41AA3C27C4F for ; Thu, 13 Jun 2024 12:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FE2I+ok3uKCOwmVddc0bcXSS9e2kqrWgkirI8+vOjPQ=; b=JPTWgGbiRwGTiWqizdZ8E2fYIQ CwJlgXSeCfp5An7ybh2PAsc4BykWnjbXa5H6tvNdRLY9nzzNyDztRg6bbZTBN1+HD3WKfvzzvFlOg KHoY0OkQJHEGtymVuVWNVMFXIVl6qU7zZFzdoCT3E41dBNQ5dv9v9BHNOZWHA8RKIAwVbGPzpUhZ8 E6j+knyYpSxq56Sm3hGKtLL9DLp1byT1frPFb9Ivz/pmIKRzdupGTxWwzkwboY0gL4ZWSVL+M1qrb CcQ0nmz4e2M+4JRPgWT/eTr/zYVZJCnZGYKdHZ/seJsTuh+zFuvDyh6jQWOJ46EyQWuqCmE31WlQV J0w39zfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHjs4-0000000GZJI-37HY; Thu, 13 Jun 2024 12:48:04 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHjrx-0000000GZEi-0Kmc for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 12:47:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B73EACE261B; Thu, 13 Jun 2024 12:47:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1011C4AF1A; Thu, 13 Jun 2024 12:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718282874; bh=S6lUckfLeB0DNVN+ciQdJA86RnrUZzC0QD5OQ0XRMQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TRXBKenEX9+k3PReXyruTVjZJAnBvKrryeGC52ULGTyVxKxgpjDQnQyoBs/YpfVcE CuBWgoEWMegQznKdP+rY6waDKmwjIvjbrVe8wOKmiK60mDqWIOLB7HkFcCvhyc/Se5 8LaJJbBXf07A+CiJgaYnFFQjMhDjG6WTDCqqX/SfAKsbYXSqZhcMId7pDbDjMsLiKJ ge+Krm3tFxCnCfiowjrJGo8uxp01a1mH+O0okS2shlmoJAJ+sdyeqPE1E9TSEv6CZ5 lofTNK1vlZQP4xhNHqBqu3eaXCKKL3lGWQGrVMHwr7tyXpYeSDJUCZjLj8gNMWKCxf /WfXizPV5vjaQ== From: Lorenzo Bianconi To: linux-clk@vger.kernel.org Cc: p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.bianconi83@gmail.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com Subject: [PATCH v3 4/4] clk: en7523: remove pcie reset open drain configuration for EN7581 Date: Thu, 13 Jun 2024 14:47:06 +0200 Message-ID: X-Mailer: git-send-email 2.45.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_054757_374249_95C3547B X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PCIE reset open drain configuration will be managed by pinctrl driver. Signed-off-by: Lorenzo Bianconi Reviewed-by: AngeloGioacchino Del Regno --- drivers/clk/clk-en7523.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index ad8a4d1ad62c..9757023601c5 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -37,8 +37,6 @@ #define REG_PCIE1_MEM_MASK 0x0c #define REG_PCIE2_MEM 0x10 #define REG_PCIE2_MEM_MASK 0x14 -#define REG_PCIE_RESET_OPEN_DRAIN 0x018c -#define REG_PCIE_RESET_OPEN_DRAIN_MASK GENMASK(2, 0) #define REG_NP_SCU_PCIC 0x88 #define REG_NP_SCU_SSTR 0x9c #define REG_PCIE_XSI0_SEL_MASK GENMASK(14, 13) @@ -85,8 +83,7 @@ struct en_clk_soc_data { const u16 *idx_map; u16 idx_map_nr; } reset; - int (*hw_init)(struct platform_device *pdev, void __iomem *base, - void __iomem *np_base); + int (*hw_init)(struct platform_device *pdev, void __iomem *np_base); }; static const u32 gsw_base[] = { 400000000, 500000000 }; @@ -411,7 +408,6 @@ static void en7581_pci_disable(struct clk_hw *hw) } static int en7581_clk_hw_init(struct platform_device *pdev, - void __iomem *base, void __iomem *np_base) { void __iomem *pb_base; @@ -434,10 +430,6 @@ static int en7581_clk_hw_init(struct platform_device *pdev, writel(0x28000000, pb_base + REG_PCIE2_MEM); writel(0xfc000000, pb_base + REG_PCIE2_MEM_MASK); - val = readl(base + REG_PCIE_RESET_OPEN_DRAIN); - writel(val | REG_PCIE_RESET_OPEN_DRAIN_MASK, - base + REG_PCIE_RESET_OPEN_DRAIN); - return 0; } @@ -584,7 +576,7 @@ static int en7523_clk_probe(struct platform_device *pdev) soc_data = device_get_match_data(&pdev->dev); if (soc_data->hw_init) { - r = soc_data->hw_init(pdev, base, np_base); + r = soc_data->hw_init(pdev, np_base); if (r) return r; }