| Message ID | afe95c2d468c0ea61ea6f04cb8689115872a5c42.1543321707.git-series.maxime.ripard@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: sunxi: Cleanup DTC warnings | expand |
On Tue, Nov 27, 2018 at 8:46 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > Some GPIO pinctrl nodes cannot be easily removed, because they would also > change the pin configuration, for example to add a pull resistor or change > the current delivered by the pin. > > Those nodes still have underscores and unit-addresses in their node names > in our DTs, so adjust their name to remove the warnings. Use that occasion > to also fix some poorly chosen node-names. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
On Wed, Nov 28, 2018 at 07:25:43PM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 27, 2018 at 8:46 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > Some GPIO pinctrl nodes cannot be easily removed, because they would also > > change the pin configuration, for example to add a pull resistor or change > > the current delivered by the pin. > > > > Those nodes still have underscores and unit-addresses in their node names > > in our DTs, so adjust their name to remove the warnings. Use that occasion > > to also fix some poorly chosen node-names. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> Applied, thanks! Maxime
diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts index 31a4b61f1d75..abc8402fe04e 100644 --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts @@ -58,7 +58,7 @@ /delete-property/stdout-path; }; - i2c_lcd: i2c@0 { + i2c_lcd: i2c-gpio { /* The lcd panel i2c interface is hooked up via gpios */ compatible = "i2c-gpio"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts index a913084c8d20..3c9f4f35d43b 100644 --- a/arch/arm/boot/dts/sun5i-r8-chip.dts +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts @@ -182,8 +182,7 @@ }; &pio { - - chip_w1_pin: chip_w1_pin@0 { + chip_w1_pin: chip-w1-pin { pins = "PD2"; function = "gpio_in"; bias-pull-up;
Some GPIO pinctrl nodes cannot be easily removed, because they would also change the pin configuration, for example to add a pull resistor or change the current delivered by the pin. Those nodes still have underscores and unit-addresses in their node names in our DTs, so adjust their name to remove the warnings. Use that occasion to also fix some poorly chosen node-names. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 2 +- arch/arm/boot/dts/sun5i-r8-chip.dts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)