From patchwork Fri Oct 26 01:48:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 1649771 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id E2E46DF2AB for ; Fri, 26 Oct 2012 01:50:15 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRZ2Y-0000I0-F1; Fri, 26 Oct 2012 01:48:50 +0000 Received: from utopia.booyaka.com ([74.50.51.50]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TRZ2U-0000Gx-NI for linux-arm-kernel@lists.infradead.org; Fri, 26 Oct 2012 01:48:47 +0000 Received: (qmail 24933 invoked by uid 1019); 26 Oct 2012 01:48:44 -0000 Date: Fri, 26 Oct 2012 01:48:44 +0000 (UTC) From: Paul Walmsley To: Afzal Mohammed , Tony Lindgren Subject: Re: [PATCH v2 06/14] mtd: onenand: omap: use pdata info instead of cpu_is In-Reply-To: <860ba92c34cbb490beccd5442087087c1751a6a2.1349672877.git.afzal@ti.com> Message-ID: References: <860ba92c34cbb490beccd5442087087c1751a6a2.1349672877.git.afzal@ti.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Artem Bityutskiy , linux-mtd@lists.infradead.org, Jon Hunter , Ivan Djelic , linux-omap@vger.kernel.org, David Woodhouse , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Afzal On Mon, 8 Oct 2012, Afzal Mohammed wrote: > platform data now contains a field to indicate whether > soc belongs to omap34xx family, use it instead of > cpu_is_* check. > > This helps in removing dependency of platform specific > header file - cpu.h > > Signed-off-by: Afzal Mohammed This one breaks an N800 multi-OMAP build here: LD init/built-in.o drivers/built-in.o: In function `omap2_onenand_probe': /home/paul/linux-bisect/drivers/mtd/onenand/omap2.c:788: undefined reference to `omap3_onenand_read_bufferram' /home/paul/linux-bisect/drivers/mtd/onenand/omap2.c:788: undefined reference to `omap3_onenand_write_bufferram' make: *** [vmlinux] Error 1 A fix is below. - Paul --- drivers/mtd/onenand/omap2.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index 53069ae..f87cf39 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -445,13 +445,19 @@ out_copy: #else -int omap3_onenand_read_bufferram(struct mtd_info *mtd, int area, - unsigned char *buffer, int offset, - size_t count); +static int omap3_onenand_read_bufferram(struct mtd_info *mtd, int area, + unsigned char *buffer, int offset, + size_t count) +{ + return -ENOSYS; +} -int omap3_onenand_write_bufferram(struct mtd_info *mtd, int area, - const unsigned char *buffer, - int offset, size_t count); +static int omap3_onenand_write_bufferram(struct mtd_info *mtd, int area, + const unsigned char *buffer, + int offset, size_t count) +{ + return -ENOSYS; +} #endif