From patchwork Wed Jan 2 19:36:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 1924841 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4F1833FC85 for ; Wed, 2 Jan 2013 19:39:53 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TqU7Y-0005sx-AN; Wed, 02 Jan 2013 19:37:00 +0000 Received: from utopia.booyaka.com ([74.50.51.50]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TqU7P-0005oR-1L for linux-arm-kernel@lists.infradead.org; Wed, 02 Jan 2013 19:36:52 +0000 Received: (qmail 19311 invoked by uid 1019); 2 Jan 2013 19:36:48 -0000 Date: Wed, 2 Jan 2013 19:36:48 +0000 (UTC) From: Paul Walmsley To: Tony Lindgren Subject: Re: [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings In-Reply-To: <20130101181319.GA22106@atomide.com> Message-ID: References: <20121224012304.13698.43551.stgit@dusk.lan> <20121224012456.13698.41839.stgit@dusk.lan> <20130101181319.GA22106@atomide.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130102_143651_340230_4BD38964 X-CRM114-Status: GOOD ( 14.69 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Vaibhav Hiremath , Santosh Shilimkar , Felipe Balbi , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi, On Tue, 1 Jan 2013, Tony Lindgren wrote: > Here it's OK to include for multiplatform builds > as the path will be included in plat-omap/Makefile. Thanks for the clarification; the patch has been updated as follows. - Paul From: Paul Walmsley Date: Mon, 10 Dec 2012 11:48:44 -0700 Subject: [PATCH] ARM: OMAP: 32k counter: resolve sparse warnings Commit 1fe97c8f6a1de67a5f56e029a818903d5bed8017 ("ARM: OMAP: Make OMAP clocksource source selection using kernel param") results in a new warning from sparse: arch/arm/plat-omap/counter_32k.c:86:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static? This second version fixes this warning by including , at Tony's request. Signed-off-by: Paul Walmsley Cc: Vaibhav Hiremath Cc: Felipe Balbi Cc: Santosh Shilimkar Cc: Kevin Hilman Cc: Tony Lindgren --- arch/arm/plat-omap/counter_32k.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c index f3771cd..5b0b86b 100644 --- a/arch/arm/plat-omap/counter_32k.c +++ b/arch/arm/plat-omap/counter_32k.c @@ -22,6 +22,8 @@ #include #include +#include + /* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */ #define OMAP2_32KSYNCNT_REV_OFF 0x0 #define OMAP2_32KSYNCNT_REV_SCHEME (0x3 << 30)