From patchwork Thu Nov 8 15:58:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 1716401 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 87C5D3FCDF for ; Thu, 8 Nov 2012 16:02:01 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWUWK-0007H7-D5; Thu, 08 Nov 2012 15:59:56 +0000 Received: from smtp02.citrix.com ([66.165.176.63]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TWUW7-0007Ft-OT for linux-arm-kernel@lists.infradead.org; Thu, 08 Nov 2012 15:59:44 +0000 X-IronPort-AV: E=Sophos;i="4.80,738,1344211200"; d="scan'208";a="213895629" Received: from ftlpex01cl01.citrite.net ([10.13.107.78]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 08 Nov 2012 15:59:41 +0000 Received: from kaball.uk.xensource.com (10.80.2.59) by FTLPEX01CL01.citrite.net (10.13.107.78) with Microsoft SMTP Server id 14.2.318.1; Thu, 8 Nov 2012 10:59:41 -0500 Date: Thu, 8 Nov 2012 15:58:55 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Stefano Stabellini Subject: Re: [Xen-devel] BUG: ARM build failures due to Xen In-Reply-To: Message-ID: References: <20121106175749.GO28327@n2100.arm.linux.org.uk> <201211081528.31968.arnd@arndb.de> <1352389245.12977.106.camel@hastur.hellion.org.uk> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-Originating-IP: [10.80.2.59] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121108_105944_051698_FC2E51A5 X-CRM114-Status: GOOD ( 18.54 ) X-Spam-Score: -3.3 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.165.176.63 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "xen-devel@lists.xensource.com" , Russell King - ARM Linux , Ian Campbell , Arnd Bergmann , Konrad Rzeszutek Wilk , "arm@kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, 8 Nov 2012, Stefano Stabellini wrote: > On Thu, 8 Nov 2012, Ian Campbell wrote: > > On Thu, 2012-11-08 at 15:28 +0000, Arnd Bergmann wrote: > > > On Tuesday 06 November 2012, Russell King - ARM Linux wrote: > > > > My build system is giving me the following errors against an OMAP4 > > > > randconfig build against the latest Linus' kernel plus arm-soc: > > > > > > > > ERROR: "privcmd_call" [drivers/xen/xen-privcmd.ko] undefined! > > > > make[2]: *** [__modpost] Error 1 > > > > make[2]: Target `_modpost' not remade because of errors. > > > > make[1]: *** [modules] Error 2 > > > > make: *** [sub-make] Error 2 > > > > make: Target `uImage' not remade because of errors. > > > > make: Target `modules' not remade because of errors. > > > > > > > > Full build results and configuration are here: > > > > > > > > http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2627 > > > > http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2627 > > > > > > > > > > I can reproduce the same thing with mainline v3.7-rc4. > > > 8<------ > > > xen/arm: export privcmd_call > > > > Thanks, Konrad posted a fix for this on Tuesday which covers a few other > > cases too: http://marc.info/?l=linux-kernel&m=135224075902642&w=2 I > > added Russell to my response but forgot to add l-a-k@ too, sorry. > > Konrad, do you have time to respin a patch that exports all the 9 > hypercalls? This is the patch that I had in mind: Acked-by: Arnd Bergmann --- From: Konrad Rzeszutek Wilk xen/arm: Fix compile errors when drivers are compiled as modules. We end up with: ERROR: "HYPERVISOR_event_channel_op" [drivers/xen/xen-gntdev.ko] undefined! ERROR: "privcmd_call" [drivers/xen/xen-privcmd.ko] undefined! ERROR: "HYPERVISOR_grant_table_op" [drivers/net/xen-netback/xen-netback.ko] undefined! and this patch exports said function (which is implemented in hypercall.S). Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 59bcb96..f576092 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -166,3 +166,14 @@ void free_xenballooned_pages(int nr_pages, struct page **pages) *pages = NULL; } EXPORT_SYMBOL_GPL(free_xenballooned_pages); + +/* In the hypervisor.S file. */ +EXPORT_SYMBOL_GPL(HYPERVISOR_event_channel_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_grant_table_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_xen_version); +EXPORT_SYMBOL_GPL(HYPERVISOR_console_io); +EXPORT_SYMBOL_GPL(HYPERVISOR_sched_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_hvm_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); +EXPORT_SYMBOL_GPL(privcmd_call);