From patchwork Fri Nov 20 12:19:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 7667221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E5F829F2E2 for ; Fri, 20 Nov 2015 12:22:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 15E5820439 for ; Fri, 20 Nov 2015 12:22:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3489120437 for ; Fri, 20 Nov 2015 12:22:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zzkg9-0000f4-4i; Fri, 20 Nov 2015 12:20:37 +0000 Received: from smtp.citrix.com ([66.165.176.89]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zzkfs-0007kX-Bb for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2015 12:20:21 +0000 X-IronPort-AV: E=Sophos;i="5.20,322,1444694400"; d="scan'208";a="313627512" Date: Fri, 20 Nov 2015 12:19:43 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Will Deacon Subject: Re: [PATCH v11 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops In-Reply-To: <20151117173557.GN30101@arm.com> Message-ID: References: <1446737696-9749-4-git-send-email-stefano.stabellini@eu.citrix.com> <20151117172914.GL30101@arm.com> <564B652C.8060409@arm.com> <20151117173557.GN30101@arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-DLP: MIA2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151120_042020_745181_AB732206 X-CRM114-Status: GOOD ( 17.66 ) X-Spam-Score: -7.5 (-------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xensource.com, linux@arm.linux.org.uk, Ian.Campbell@citrix.com, arnd@arndb.de, konrad.wilk@oracle.com, Marc Zyngier , catalin.marinas@arm.com, Stefano Stabellini , linux-kernel@vger.kernel.org, nico@linaro.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org, cov@codeaurora.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 17 Nov 2015, Will Deacon wrote: > On Tue, Nov 17, 2015 at 05:34:36PM +0000, Marc Zyngier wrote: > > On 17/11/15 17:29, Will Deacon wrote: > > > On Tue, Nov 10, 2015 at 02:11:38PM +0000, Stefano Stabellini wrote: > > >> On Thu, 5 Nov 2015, Stefano Stabellini wrote: > > >>> Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM64. > > >>> Necessary duplication of paravirt.h and paravirt.c with ARM. > > >>> > > >>> The only paravirt interface supported is pv_time_ops.steal_clock, so no > > >>> runtime pvops patching needed. > > >>> > > >>> This allows us to make use of steal_account_process_tick for stolen > > >>> ticks accounting. > > >>> > > >>> Signed-off-by: Stefano Stabellini > > >>> Acked-by: Marc Zyngier > > >> > > >> Ping? > > >> > > >> Catalin, Will, > > >> are you happy with this change? > > > > > > I'm happy if Marc's happy. Marc? > > > > My Ack is already on the tin! ;-) > > Ah yes, I only saw the cc line. In which case, I assume Stefano will > take this via the xen tree. Unfortunately I am still missing Russell's ack on the arm patch (3/5). Would you be OK if I dropped stolen time support for arm, only keeping the arm64 part? The price to pay is two small ifdefs in arch/arm/xen/enlighten.c: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 15621b1..87e2fec 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -16,7 +16,9 @@ #include #include #include +#ifdef ARM64 #include +#endif #include #include #include @@ -289,9 +291,10 @@ static int __init xen_guest_init(void) register_cpu_notifier(&xen_cpu_notifier); +#ifdef ARM64 pv_time_ops.steal_clock = xen_stolen_accounting; static_key_slow_inc(¶virt_steal_enabled); - +#endif return 0; } early_initcall(xen_guest_init);