From patchwork Mon Apr 14 17:12:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Christoph Lameter (Ampere)" X-Patchwork-Id: 3984551 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 23ACE9F2BA for ; Mon, 14 Apr 2014 17:15:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4974620120 for ; Mon, 14 Apr 2014 17:15:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79A302011D for ; Mon, 14 Apr 2014 17:15:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WZkRi-0008Ng-5m; Mon, 14 Apr 2014 17:13:26 +0000 Received: from qmta14.emeryville.ca.mail.comcast.net ([2001:558:fe2d:44:76:96:27:212]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WZkRa-0008FW-CZ for linux-arm-kernel@lists.infradead.org; Mon, 14 Apr 2014 17:13:18 +0000 Received: from omta14.emeryville.ca.mail.comcast.net ([76.96.30.60]) by qmta14.emeryville.ca.mail.comcast.net with comcast id pqgc1n0031HpZEsAEtCvCJ; Mon, 14 Apr 2014 17:12:55 +0000 Received: from gentwo.org ([98.213.233.247]) by omta14.emeryville.ca.mail.comcast.net with comcast id ptCt1n00H5Lw0ES8atCuDl; Mon, 14 Apr 2014 17:12:54 +0000 Received: by gentwo.org (Postfix, from userid 1001) id E4D382BA7; Mon, 14 Apr 2014 12:12:52 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id E0A1F27D0; Mon, 14 Apr 2014 12:12:52 -0500 (CDT) Date: Mon, 14 Apr 2014 12:12:52 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@nuc To: Grygorii Strashko Subject: Re: [3.15-rc1] a huge number of warnings produced by xhci & In-Reply-To: <534C182C.8040206@ti.com> Message-ID: References: <53285FE7.5010203@ti.com> <534C182C.8040206@ti.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1397495575; bh=dTHyiMQixEu8VgEyK/BOM9AknWGk2Tj55VXi1tKyjWM=; h=Received:Received:Received:Received:Date:From:To:Subject: Message-ID:Content-Type; b=JXZTmuEVhq2RewNrN8sALugfhhC56kkvrpooobMbLaCjePp7sPjEh9vCE/Jf9Cmdh SXj2UHUBhqF/EVNO3FTxSWmGbt/f3wehUVg1S++I7N6Drc23yK6ZPFMxpCkitGVD+7 +MWhmQMm2SohsDjyjFHRYorC5VJlleC2dD8XKzwIdvLO2tbRnbgmHMEz8ZMXpuHO0L EL5hVbQpnooxd2TKgOjPG+b6T3jJVO2vIiL9IgLZdIwigUSAM4HEFGVqJqeR4a7tHv NUrfTm4FoLpE0TPXOY0aRVoWOrQmf42ZH3S1uy5n858YcKw+eqfTWgSwSoioqiSqf6 ohOXWV2gqS+HQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140414_101318_452898_C307C5A8 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Santosh Shilimkar , Tejun Heo , Andrew Morton , Ingo Molnar , linux-arm X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP n Mon, 14 Apr 2014, Grygorii Strashko wrote: > Hi All, > > I'm observing a huge number of warnings produced during the boot of my Keystone 2 board > when USB is enabled. > > [ 2.496460] BUG: using __this_cpu_read() in preemptible [00000000] code: khubd/202 > [ 2.504030] caller is __mod_zone_page_state+0x20/0xc8 > [ 2.509094] CPU: 1 PID: 202 Comm: khubd Not tainted 3.15.0-rc1-00015-ge521fa3-dirty #55 > [ 2.517122] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 2.524854] [] (show_stack) from [] (dump_stack+0x68/0xb8) > [ 2.532086] [] (dump_stack) from [] (check_preemption_disabled+0xe8/0x10c) > [ 2.540708] [] (check_preemption_disabled) from [] (__mod_zone_page_state+0x20/0xc8) > [ 2.550187] [] (__mod_zone_page_state) from [] (reclaim_clean_pages_from_list+0x16c/0x178) > [ 2.560193] [] (reclaim_clean_pages_from_list) from [] (alloc_contig_range+0x10c/0x2d0) > [ 2.569932] [] (alloc_contig_range) from [] (dma_alloc_from_contiguous+0x70/0x118) > [ 2.579241] [] (dma_alloc_from_contiguous) from [] (__alloc_from_contiguous+0x34/0x160) > [ 2.588974] [] (__alloc_from_contiguous) from [] (__dma_alloc+0x18c/0x294) > [ 2.597582] [] (__dma_alloc) from [] (arm_dma_alloc+0xac/0xd8) > [ 2.605140] [] (arm_dma_alloc) from [] (dma_pool_alloc+0xc8/0x1b8) > [ 2.613067] [] (dma_pool_alloc) from [] (xhci_alloc_container_ctx+0x70/0xe0) > [ 2.621851] [] (xhci_alloc_container_ctx) from [] (xhci_alloc_virt_device+0x98/0x220) > [ 2.631418] [] (xhci_alloc_virt_device) from [] (xhci_alloc_dev+0x158/0x1f0) > [ 2.640207] [] (xhci_alloc_dev) from [] (usb_alloc_dev+0x1d4/0x27c) > [ 2.648217] [] (usb_alloc_dev) from [] (hub_thread+0x670/0x1204) > [ 2.655943] [] (hub_thread) from [] (kthread+0xcc/0xe8) > [ 2.662906] [] (kthread) from [] (ret_from_fork+0x14/0x3c) > > Anyone else sees the same thing? Either disable interrupts or use mod_zone_page_state instead. This should fix it: Subject: vmscan: reclaim_clean_pages_from_list must use mod_zone_page_state Seems to be called with preemption enabled. Therefore it must use mod_zone_page_state instead. Signed-off-by: Christoph Lameter Tested-by: Grygorii Strashko Index: linux/mm/vmscan.c =================================================================== --- linux.orig/mm/vmscan.c 2014-04-09 11:35:43.917930976 -0500 +++ linux/mm/vmscan.c 2014-04-14 12:09:48.070745938 -0500 @@ -1158,7 +1158,7 @@ unsigned long reclaim_clean_pages_from_l TTU_UNMAP|TTU_IGNORE_ACCESS, &dummy1, &dummy2, &dummy3, &dummy4, &dummy5, true); list_splice(&clean_pages, page_list); - __mod_zone_page_state(zone, NR_ISOLATED_FILE, -ret); + mod_zone_page_state(zone, NR_ISOLATED_FILE, -ret); return ret; }