From patchwork Tue Apr 10 05:49:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 10332355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AE1296028A for ; Tue, 10 Apr 2018 06:01:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96A0D28CD3 for ; Tue, 10 Apr 2018 06:01:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 92F0A28CD8; Tue, 10 Apr 2018 06:01:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4063728CF0 for ; Tue, 10 Apr 2018 06:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=aEFR2Y4Aesgxy7TNk3EwRxRjx8lcKQV9/OS8g3qIAQk=; b=mQmyjT/SIkIjPp dJ+Hu8gil5YxvMgtRPuHkrKEhGqrmKKumYXasbcR+YFvEKIfIvn+VLRyjkYFVwY0vkWJajtEteSO0 GsTb4kdcYPfd0XXkv2tJ/eXmUS5I/KTlZMMLOLECVk3k6aP/k8g6cHgttvyjepGq8yvjUYp6ke8ye 4oeH0BtN/BX1zld3GrYyTg7Ix+8NNB2VC9CrcM9FQo6nbXXyrIdqs9mDFqktdEW+pjd0rHtZXaKy3 Zz/XGqGVxJme/gD4kYKN5SOIydmKKOBxE62N4SbwNlzrGb60NWjXPRg6+MsUprCn/sz47tZAlzN3n fIzvkXOmIHShJ3myryVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f5mLh-0002gt-CD; Tue, 10 Apr 2018 06:01:45 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f5mLd-0002g2-5c for linux-arm-kernel@lists.infradead.org; Tue, 10 Apr 2018 06:01:43 +0000 X-IronPort-AV: E=Sophos;i="5.48,430,1517871600"; d="scan'208";a="261452898" Received: from ip-146.net-89-2-7.rev.numericable.fr (HELO [192.168.0.15]) ([89.2.7.146]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 07:49:41 +0200 Date: Tue, 10 Apr 2018 07:49:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Hyun Kwon Subject: [PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180409_230141_508416_B5A1CAAB X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , linux-arm-kernel@lists.infradead.org, kbuild-all@01.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fengguang Wu PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls") CC: Hyun Kwon Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Reviewed-by: Laurent Pinchart --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14 head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx: pl_disp: Use xlnx pipeline calls xlnx_pl_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/xlnx/xlnx_pl_disp.c +++ b/drivers/gpu/drm/xlnx/xlnx_pl_disp.c @@ -482,7 +482,7 @@ static int xlnx_pl_disp_probe(struct pla xlnx_pl_disp->master = xlnx_drm_pipeline_init(pdev); if (IS_ERR(xlnx_pl_disp->master)) { - ret = PTR_ERR(xlnx_pl_disp->dev); + ret = PTR_ERR(xlnx_pl_disp->master); dev_err(dev, "failed to initialize the drm pipeline\n"); goto err_component; }