diff mbox series

iommu: dart: fix call_kern.cocci warnings

Message ID alpine.DEB.2.22.394.2104041724340.2958@hadrien (mailing list archive)
State New, archived
Headers show
Series iommu: dart: fix call_kern.cocci warnings | expand

Commit Message

Julia Lawall April 4, 2021, 3:26 p.m. UTC 
From: kernel test robot <lkp@intel.com>

Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head:   1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago

Please take the patch only if it's a positive warning. Thanks!

 apple-dart-iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sven Peter April 9, 2021, 4:49 p.m. UTC | #1 
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL

Thanks! Fixed for v3.


Best,


Sven
diff mbox series

Patch

--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@  static int apple_dart_attach_stream(stru
 		goto error;
 	}

-	stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+	stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
 	if (!stream) {
 		ret = -ENOMEM;
 		goto error;