| Message ID | b3b8320f0d2b54a0557331977582d05c@rnplus.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: allwinner: a64: add device tree for SoPine with clusterboard | expand |
On 06/11/2022 22:40, renze@rnplus.nl wrote: > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai <renze@rnplus.nl> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts | 10 ++++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb This does not look like matching indentation of other entries... > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..6f8020a22670 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" You miss compatible and model. You need to document the compatible in bindings (just like other top-level). > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index 6a96494a2e0a..15b011d1aaea 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644 index 000000000000..6f8020a22670 --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts @@ -0,0 +1,10 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> + +/dts-v1/; + +#include "sun50i-a64-sopine-baseboard.dts" + +&emac { + allwinner,tx-delay-ps = <500>; +};
The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it. Add a device tree for SoPine with the clusterboard. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts | 10 ++++++++++ 2 files changed, 11 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts