| Message ID | b4b2bb2d7747f8c9223fb50fd2868f77a7c7f63a.1435220957.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 25, 2015 at 5:29 PM, Michal Simek <michal.simek@xilinx.com> wrote: > Add missing pm_runtime_disabled to remove(). > > Error log: > root@zynqmp:~# modprobe gpio_zynq > root@zynqmp:~# lsmod > Not tainted > gpio_zynq 7086 0 - Live 0xffffffbffc00a000 > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted > root@zynqmp:~# modprobe gpio_zynq > [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable! > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted Yup, this was missing indeed. Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/gpio/gpio-zynq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index 2e87c4b8da26..a78882389836 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev) > gpiochip_remove(&gpio->chip); > clk_disable_unprepare(gpio->clk); > device_set_wakeup_capable(&pdev->dev, 0); > + pm_runtime_disable(&pdev->dev); > return 0; > } > > -- > 2.3.5 >
On Thu, Jun 25, 2015 at 10:29 AM, Michal Simek <michal.simek@xilinx.com> wrote: > Add missing pm_runtime_disabled to remove(). > > Error log: > root@zynqmp:~# modprobe gpio_zynq > root@zynqmp:~# lsmod > Not tainted > gpio_zynq 7086 0 - Live 0xffffffbffc00a000 > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted > root@zynqmp:~# modprobe gpio_zynq > [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable! > root@zynqmp:~# rmmod gpio_zynq > root@zynqmp:~# lsmod > Not tainted > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Patch applied with Alex' ACK. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 2e87c4b8da26..a78882389836 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev) gpiochip_remove(&gpio->chip); clk_disable_unprepare(gpio->clk); device_set_wakeup_capable(&pdev->dev, 0); + pm_runtime_disable(&pdev->dev); return 0; }
Add missing pm_runtime_disabled to remove(). Error log: root@zynqmp:~# modprobe gpio_zynq root@zynqmp:~# lsmod Not tainted gpio_zynq 7086 0 - Live 0xffffffbffc00a000 root@zynqmp:~# rmmod gpio_zynq root@zynqmp:~# lsmod Not tainted root@zynqmp:~# modprobe gpio_zynq [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable! root@zynqmp:~# rmmod gpio_zynq root@zynqmp:~# lsmod Not tainted Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+)