[3/6] ARM: s3c2410: Fix a typo in a comment line

Commit Message

SF Markus Elfring Oct. 2, 2017, 6 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Mon, 2 Oct 2017 19:34:36 +0200

Adjust a word in this function description.

Signed-off-by: Markus Elfring <[e-mail]>
---
 arch/arm/mach-s3c24xx/iotiming-s3c2410.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 4, 2017, 6:14 p.m. UTC | #1

On Mon, Oct 02, 2017 at 08:00:27PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <[e-mail]>
> Date: Mon, 2 Oct 2017 19:34:36 +0200
> 
> Adjust a word in this function description.
> 
> Signed-off-by: Markus Elfring <[e-mail]>
> ---
>  arch/arm/mach-s3c24xx/iotiming-s3c2410.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks, applied, squashed and changed commit msg.

Best regards,
Krzysztof

SF Markus Elfring Oct. 10, 2017, 8:29 a.m. UTC | #2

> Thanks, applied, squashed and changed commit msg.

Would it be more appropriate to use a commit subject like
“ARM: s3c241x: Fix typos in two comments” (instead of
“ARM: s3c2410: Fix typos in a comments”)?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c7a7db2e4c25acf8bd8086797d39a51728139e0

Regards,
Markus

Krzysztof Kozlowski Oct. 10, 2017, 8:35 a.m. UTC | #3

On Tue, Oct 10, 2017 at 10:29 AM, SF Markus Elfring
<[e-mail]> wrote:
>> Thanks, applied, squashed and changed commit msg.
>
> Would it be more appropriate to use a commit subject like
> “ARM: s3c241x: Fix typos in two comments” (instead of
> “ARM: s3c2410: Fix typos in a comments”)?
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c7a7db2e4c25acf8bd8086797d39a51728139e0

Yes, it would but patch is already applied and I prefer to avoid
rebasing unless really necessary.

Best regards,
Krzysztof

SF Markus Elfring Oct. 10, 2017, 8:48 a.m. UTC | #4

>>> Thanks, applied, squashed and changed commit msg.
>>
>> Would it be more appropriate to use a commit subject like
>> “ARM: s3c241x: Fix typos in two comments” (instead of
>> “ARM: s3c2410: Fix typos in a comments”)?
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c7a7db2e4c25acf8bd8086797d39a51728139e0
> 
> Yes, it would but patch is already applied and I prefer to avoid
> rebasing unless really necessary.

I would appreciate also a corresponding correct commit message.
Is it interesting that this change attempt seems to have caused another unwanted typo?

Regards,
Markus

Patch

diff --git a/arch/arm/mach-s3c24xx/iotiming-s3c2410.c b/arch/arm/mach-s3c24xx/iotiming-s3c2410.c
index c18769b5f15a..d5f1f06e4811 100644
--- a/arch/arm/mach-s3c24xx/iotiming-s3c2410.c
+++ b/arch/arm/mach-s3c24xx/iotiming-s3c2410.c
@@ -206,7 +206,7 @@  static int calc_tacc(unsigned int cyc, int nwait_en,
 }
 
 /**
- * s3c2410_calc_bank - calculate bank timing infromation
+ * s3c2410_calc_bank - calculate bank timing information
  * @cfg: The configuration we need to calculate for.
  * @bt: The bank timing information.
  *