From patchwork Wed Nov 8 21:09:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H. Nikolaus Schaller" X-Patchwork-Id: 10049391 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8D56A6032D for ; Wed, 8 Nov 2017 21:11:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D286298F9 for ; Wed, 8 Nov 2017 21:11:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E3692990A; Wed, 8 Nov 2017 21:11:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 67DDC2990A for ; Wed, 8 Nov 2017 21:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1rQvypA23eGz3CcRLTnB0hvnNBuF2aSTr5b+9BYW51s=; b=XMbQFpvE0oE+wkcJFmf+ooKF19 ACDAWLDf5kqRXD1MExtfzQ4PjaNU5O5yz8dKSSchPbuDABSue7d/V9KSUXBgEw/RPTY27UNVBL/bG U7Ww78ft5oCMtwClWt8BpadFmwkvLNIj8guaZkd7ZP6ImqSOMIH3DoyepHUnmTJVwqC0LeUovSJLH Euil98Cl4SufuJUefylaoyEYcAiwYWeUzrAbp72YlRi8bIZLP1xK4o91yORhWgmIYDv5Z3NY82S1Y HW+w2TMGS98P8uq9Rck2TtGkBiHhiIzMNsk/iyQKoRQdFbac4k+MnHdsy92Y5RDTxW8tSMoXlil6z dkyI07FQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCXd1-0002GP-5v; Wed, 08 Nov 2017 21:11:19 +0000 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::6]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCXbz-0008Np-Dv for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2017 21:10:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1510175384; s=domk; d=goldelico.com; h=References:In-Reply-To:References:In-Reply-To:Date:Subject:Cc:To: From; bh=6Shb5wlU6KY8VZtii+VaStKJsOqAclhx+WK+EKSeMnY=; b=wqIp4G02R5JXXOHtl9BEJ+yBHQym4kb12ndyGK+xuq6POTCN/3aGijxhiF7UT5sVlD 4sQbfK5dZG2zRZKKIh0pk6vmv84NgEgpRC/gtpb0tx4s8FVqzShrjKQ7KPTkH4fgzPeF TiPcHawAX8Rfb6BNU25qNAYBPl/jcTquBNjKc= X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw87WisNN1Ez+Y X-RZG-CLASS-ID: mo00 Received: from localhost.localdomain (p57AE0883.dip0.t-ipconnect.de [87.174.8.131]) by smtp.strato.de (RZmta 42.9 DYNA|AUTH) with ESMTPSA id f05bb6tA8L9aQhJ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 8 Nov 2017 22:09:36 +0100 (CET) From: "H. Nikolaus Schaller" To: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?UTF-8?q?Beno=C3=AEt=20Cousson?= , Tony Lindgren , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , "H. Nikolaus Schaller" , Julia Lawall , Sean Paul Subject: [PATCH 4/4] omapdss: fix problem enabling VDDS_DSI on OMAP3530 (OpenPandora) Date: Wed, 8 Nov 2017 22:09:32 +0100 Message-Id: X-Mailer: git-send-email 2.12.2 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171108_131015_733192_C5DAB561 X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@pyra-handheld.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP commit d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature to dpi code") introduced a new match table which turned out to be wrong, at least for the 600 MHz OpenPandora using the OMAP3530. The effect was strange: only the Blue channel of the RGB panel was driven while Red and Green stayed black. So a coloured picture turned into blue/black. The GTA04 with DM3730 didn't show the effect. It turned out that VDDS_DSI was not properly initialized on OMAP3530, because the .family string is just "OMAP3" for these processors and not "OMAP3xxx". Therefore we match the .machine attribute. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c index 4ed5fde11313..aae3626910bb 100644 --- a/drivers/gpu/drm/omapdrm/dss/dpi.c +++ b/drivers/gpu/drm/omapdrm/dss/dpi.c @@ -566,8 +566,7 @@ static int dpi_verify_pll(struct dss_pll *pll) } static const struct soc_device_attribute dpi_soc_devices[] = { - { .family = "OMAP3[456]*" }, - { .family = "[AD]M37*" }, + { .machine = "OMAP3[456]*" }, { /* sentinel */ } };