From patchwork Wed Nov 20 15:45:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254299 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CC9113A4 for ; Wed, 20 Nov 2019 15:46:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D0D42071F for ; Wed, 20 Nov 2019 15:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TdBtg9V3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E3AnSLk8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D0D42071F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vyrawdsRuaOJ+QioFK0qcKXyb0Uk0kxRWfZwNnzDWaA=; b=TdBtg9V3RqQF3S+iTwzLap2M8D BOJwbKLknFOP2nY+NHRqiXWgNwXVKTrpXIPhNNot6c600whPTF5ORJ9zvmMoJs+qzhIVnXIEOYXL7 fLikW+woLN9xS43B4f3yceZ0QoaOOQuUYKqNwI6hlLSmh2aQO+LH2PqF4+WTx2N3Z7v7Lqtlsp1DP ZmAeGNewyIZbS1j0TaZMOKI1QphSyzcWDUSIpGx3ig4Vtawe2+Xy9+bHHyLgH22B1Nta+Mesxvi6s CrRwF6aBMp1tf17ys3JF0xy6PPHVChz6QzC6IG2KgiRSHt19CjjCI9D6rNAaNsVCkYljhwJA08bzc td2M57SQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXSB6-0003Ft-Hc; Wed, 20 Nov 2019 15:46:00 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXSAx-00039b-Lu for linux-arm-kernel@lists.infradead.org; Wed, 20 Nov 2019 15:45:56 +0000 Received: by mail-pf1-x444.google.com with SMTP id q26so14387668pfn.11 for ; Wed, 20 Nov 2019 07:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=E3AnSLk8a93bsgWxr4fcB/GPFvJ4Rxo5soxyRn5bqg6l49xuRK6YcbzlIUUW+u31d/ JA22kRY/pMbbK6pIyxFgfeLHI+IcM3+2nwmI0qvXJDZabbmDuqUiVLRhLr/SlgQh51oV UsRDODil4tFnA/SKcLzQnQ+fH8TLmKtJQuaXjNyammLFz8sJfJUN/4NBihEftSt/l1LP x+sqw0txJaK5+awwGSe60/jM8OFzrCCRY2WBzh7ui94S3wFWodQ+jtN2oCBeDML5mYft gGYXdwx2NpSBdm09KeHKgUEzj1qYlvdnhYlD26aXvxQF6VchwF5Zd1bpM9qETPcn/vAF N3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=ZUlZ2lrlPLRiHl7r6FGGIld/ZF/cxjnMFKhCvD+JD00qeqc3xnUKN7cHanO6dzvux4 G/sDkqjou3EHYFjezUtCifWfZtz/3uKawJTzXi+TBUsDA7FP0G+tkO641NtkgWxWTflL 8woVsFHPXIlc1PvdwOeMjB8mdAdDlap/eEBEjad0y51DfLeeX1+XLiR7MUzpcvymF8Pt e8Ds/nynzuCORxjLXgkOKvXGPHBrkU7u094yZ0Jov8eGJqsaxLmDMdjVgE40eV5wB1Qz D5NGnM3zTK/eYx2HID2AHZDWn7ujPWaPX/liLGBcpKsW7/PGMiz+c1TEn9xPNrPfTYrT PmKw== X-Gm-Message-State: APjAAAU0nz/aoP/rIKenckOpJgZSlN6LlQQmX7lKpE9fsDe0c34Zs+Y3 KnA36m5MUyIfzKvXJ6dX0UpO3A== X-Google-Smtp-Source: APXvYqzj7lopeOEFvFadHOn4FAisXgAAfQF8EcvPp5oAfbvhy/8a9sOXfobTdg947a+fRpG3+UQUCw== X-Received: by 2002:a63:d20f:: with SMTP id a15mr4164989pgg.268.1574264750264; Wed, 20 Nov 2019 07:45:50 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id u20sm30558372pgo.50.2019.11.20.07.45.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:49 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Subject: [PATCH v2 06/11] thermal: mediatek: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:15 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_074551_812319_4F3368B7 X-CRM114-Status: GOOD ( 13.76 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/mtk_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index acf4854cbb8b..76e30603d4d5 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; -/** +/* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 * temperature sensors. We use each bank to measure a certain area of the @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { .sensor_mux_values = mt8173_mux_values, }; -/** +/* * The MT2701 thermal controller has one bank, which can read up to * three temperature sensors simultaneously. The MT2701 has a total of 3 * temperature sensors. @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .sensor_mux_values = mt2701_mux_values, }; -/** +/* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 * temperature sensors. @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .sensor_mux_values = mt7622_mux_values, }; -/** +/* * The MT8183 thermal controller has one bank for the current SW framework. * The MT8183 has a total of 6 temperature sensors. * There are two thermal controller to control the six sensor. @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { * data, and this indeed needs the temperatures of the individual banks * for making better decisions. */ - static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, .num_banks = MT8183_NUM_SENSORS_PER_ZONE, @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { /** * raw_to_mcelsius - convert a raw ADC value to mcelsius - * @mt: The thermal controller + * @mt: The thermal controller + * @sensno: sensor number * @raw: raw ADC value * * This converts the raw ADC value to mcelsius using the SoC specific