diff mbox series

[v2,1/2] dt-bindings: pwm: Document Airoha EN7581 PWM

Message ID bd0528c45c2e2efb799b59ce503ab8fed196df07.1723393857.git.lorenzo@kernel.org (mailing list archive)
State New, archived
Headers show
Series Add PWM support to EN7581 | expand

Commit Message

Lorenzo Bianconi Aug. 11, 2024, 4:34 p.m. UTC 
From: Christian Marangi <ansuelsmth@gmail.com>

Document required property for the Airoha EN7581 PWM. The device
requires 3 different address for the sgpio, flash and cycle config.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 .../bindings/pwm/airoha,en7581-pwm.yaml       | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml

Comments

Krzysztof Kozlowski Aug. 12, 2024, 9:23 a.m. UTC | #1 
On 11/08/2024 18:34, Lorenzo Bianconi wrote:
> From: Christian Marangi <ansuelsmth@gmail.com>
> 
> Document required property for the Airoha EN7581 PWM. The device
> requires 3 different address for the sgpio, flash and cycle config.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

That's odd placement. Which tool placed it that way?

> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Best regards,
Krzysztof
Lorenzo Bianconi Aug. 12, 2024, 9:58 a.m. UTC | #2 
> On 11/08/2024 18:34, Lorenzo Bianconi wrote:
> > From: Christian Marangi <ansuelsmth@gmail.com>
> > 
> > Document required property for the Airoha EN7581 PWM. The device
> > requires 3 different address for the sgpio, flash and cycle config.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> That's odd placement. Which tool placed it that way?

I placed it manually. Do you prefer to put the Reviewed-by tag at the end if
the patch is unchanged?

Regards,
Lorenzo

> 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Aug. 12, 2024, 1:26 p.m. UTC | #3 
On 12/08/2024 11:58, Lorenzo Bianconi wrote:
>> On 11/08/2024 18:34, Lorenzo Bianconi wrote:
>>> From: Christian Marangi <ansuelsmth@gmail.com>
>>>
>>> Document required property for the Airoha EN7581 PWM. The device
>>> requires 3 different address for the sgpio, flash and cycle config.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> That's odd placement. Which tool placed it that way?
> 
> I placed it manually. Do you prefer to put the Reviewed-by tag at the end if
> the patch is unchanged?

Please do not place tags manually unless you carefully follow submitting
patches and DCO process. Use b4 for this.

Tag must be moved further, because here it is placed incorrectly.
Christian did not send this patch after receiving my review. I did not
review it before he wrote it, either.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml b/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml
new file mode 100644
index 000000000000..52470668f90e
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml
@@ -0,0 +1,42 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/airoha,en7581-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha EN7581 PWM
+
+maintainers:
+  - Christian Marangi <ansuelsmth@gmail.com>
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    const: airoha,en7581-pwm
+
+  reg:
+    items:
+      - description: sgpio config address
+      - description: flash config address
+      - description: cycle config address
+
+  "#pwm-cells":
+    const: 3
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm@1fbf0224 {
+        compatible = "airoha,en7581-pwm";
+        reg = <0x1fbf0224 0x10>,
+              <0x1fbf0238 0x28>,
+              <0x1fbf0298 0x8>;
+        #pwm-cells = <3>;
+    };