| Message ID | c55f85d694cf6cd29fbd072b9246dda296ca6639.1660027440.git.ming.qian@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: amphion: add support for contiguous format | expand |
Hi Ming, On Tue, Aug 09, 2022 at 02:50:40PM +0800, Ming Qian wrote: > decoder add support for contiguous formats > V4L2_PIX_FMT_NV12_8L128 and V4L2_PIX_FMT_NV12_10BE_8L128 > > Signed-off-by: Ming Qian <ming.qian@nxp.com> > --- > drivers/media/platform/amphion/vdec.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c > index 48ab664fa7ef..9c3324717cbc 100644 > --- a/drivers/media/platform/amphion/vdec.c > +++ b/drivers/media/platform/amphion/vdec.c > @@ -72,12 +72,28 @@ static const struct vpu_format vdec_formats[] = { > .mem_planes = 2, > .comp_planes = 2, > .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12_8L128, > + }, > + { > + .pixfmt = V4L2_PIX_FMT_NV12_8L128, > + .mem_planes = 1, > + .comp_planes = 2, > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12M_8L128, > }, > { > .pixfmt = V4L2_PIX_FMT_NV12M_10BE_8L128, > .mem_planes = 2, > .comp_planes = 2, > .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12_10BE_8L128, > + }, > + { > + .pixfmt = V4L2_PIX_FMT_NV12_10BE_8L128, > + .mem_planes = 1, > + .comp_planes = 2, > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12M_10BE_8L128 > }, > { > .pixfmt = V4L2_PIX_FMT_H264, > -- > 2.37.1 > Looks good to me. Unfortunately I don't have hw for testing more. I tried to build and reviewed the code seems ok for me. Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> Tommaso
diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c index 48ab664fa7ef..9c3324717cbc 100644 --- a/drivers/media/platform/amphion/vdec.c +++ b/drivers/media/platform/amphion/vdec.c @@ -72,12 +72,28 @@ static const struct vpu_format vdec_formats[] = { .mem_planes = 2, .comp_planes = 2, .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .sibling = V4L2_PIX_FMT_NV12_8L128, + }, + { + .pixfmt = V4L2_PIX_FMT_NV12_8L128, + .mem_planes = 1, + .comp_planes = 2, + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .sibling = V4L2_PIX_FMT_NV12M_8L128, }, { .pixfmt = V4L2_PIX_FMT_NV12M_10BE_8L128, .mem_planes = 2, .comp_planes = 2, .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .sibling = V4L2_PIX_FMT_NV12_10BE_8L128, + }, + { + .pixfmt = V4L2_PIX_FMT_NV12_10BE_8L128, + .mem_planes = 1, + .comp_planes = 2, + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .sibling = V4L2_PIX_FMT_NV12M_10BE_8L128 }, { .pixfmt = V4L2_PIX_FMT_H264,
decoder add support for contiguous formats V4L2_PIX_FMT_NV12_8L128 and V4L2_PIX_FMT_NV12_10BE_8L128 Signed-off-by: Ming Qian <ming.qian@nxp.com> --- drivers/media/platform/amphion/vdec.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)