| Message ID | c6bbb3884e9270a203ee39d298c34f6676b3911e.1723653439.git.jan.kiszka@siemens.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: k3: Resolve remaining dtbs_check warnings | expand |
On Wed, Aug 14, 2024 at 06:37:18PM +0200, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > Expand bindings to cover both the MCU and the main usage of the AM654 > system controller. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On 18:37-20240814, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > Expand bindings to cover both the MCU and the main usage of the AM654 > system controller. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > index e79803e586ca..cb9da3ec39a8 100644 > --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml As per linux-next, this file does not exist? looks like you might need to rebase on latest next? > @@ -29,11 +29,30 @@ properties: > > ranges: true > > + dss-oldi-io-ctrl@41e0: > + type: object > + $ref: /schemas/mfd/syscon.yaml# > + properties: > + compatible: > + items: > + - const: ti,am654-dss-oldi-io-ctrl > + - const: syscon > + > + clock-controller@4140: > + type: object > + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# > + description: > + Clock provider for TI EHRPWM nodes. > + > patternProperties: > "^phy@[0-9a-f]+$": > type: object > $ref: /schemas/phy/ti,phy-gmii-sel.yaml# > > + "^clock@[0-9a-f]+$": > + type: object > + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# > + > required: > - compatible > - reg > -- > 2.43.0 >
On 24.08.24 19:58, Nishanth Menon wrote: > On 18:37-20240814, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kiszka@siemens.com> >> >> Expand bindings to cover both the MCU and the main usage of the AM654 >> system controller. >> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> --- >> .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >> index e79803e586ca..cb9da3ec39a8 100644 >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > > As per linux-next, this file does not exist? looks like you might need > to rebase on latest next? > "This goes on top of https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/" Is that series obsolete by now? Jan >> @@ -29,11 +29,30 @@ properties: >> >> ranges: true >> >> + dss-oldi-io-ctrl@41e0: >> + type: object >> + $ref: /schemas/mfd/syscon.yaml# >> + properties: >> + compatible: >> + items: >> + - const: ti,am654-dss-oldi-io-ctrl >> + - const: syscon >> + >> + clock-controller@4140: >> + type: object >> + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# >> + description: >> + Clock provider for TI EHRPWM nodes. >> + >> patternProperties: >> "^phy@[0-9a-f]+$": >> type: object >> $ref: /schemas/phy/ti,phy-gmii-sel.yaml# >> >> + "^clock@[0-9a-f]+$": >> + type: object >> + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# >> + >> required: >> - compatible >> - reg >> -- >> 2.43.0 >> >
On 13:31-20240826, Jan Kiszka wrote: > On 24.08.24 19:58, Nishanth Menon wrote: > > On 18:37-20240814, Jan Kiszka wrote: > >> From: Jan Kiszka <jan.kiszka@siemens.com> > >> > >> Expand bindings to cover both the MCU and the main usage of the AM654 > >> system controller. > >> > >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > >> --- > >> .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ > >> 1 file changed, 19 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > >> index e79803e586ca..cb9da3ec39a8 100644 > >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > > > > As per linux-next, this file does not exist? looks like you might need > > to rebase on latest next? > > > > "This goes on top of > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/" > > Is that series obsolete by now? This dependency information would have been useful when provided under the diffstat section of the representative patch. :(
On 26.08.24 13:42, Nishanth Menon wrote: > On 13:31-20240826, Jan Kiszka wrote: >> On 24.08.24 19:58, Nishanth Menon wrote: >>> On 18:37-20240814, Jan Kiszka wrote: >>>> From: Jan Kiszka <jan.kiszka@siemens.com> >>>> >>>> Expand bindings to cover both the MCU and the main usage of the AM654 >>>> system controller. >>>> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >>>> --- >>>> .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ >>>> 1 file changed, 19 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>>> index e79803e586ca..cb9da3ec39a8 100644 >>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>> >>> As per linux-next, this file does not exist? looks like you might need >>> to rebase on latest next? >>> >> >> "This goes on top of >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/" >> >> Is that series obsolete by now? > > This dependency information would have been useful when provided under the > diffstat section of the representative patch. :( > Yeah, who reads cover letters? ;) Will try to do that next time. Jan
On 14:01-20240826, Jan Kiszka wrote: > On 26.08.24 13:42, Nishanth Menon wrote: > > On 13:31-20240826, Jan Kiszka wrote: > >> On 24.08.24 19:58, Nishanth Menon wrote: > >>> On 18:37-20240814, Jan Kiszka wrote: > >>>> From: Jan Kiszka <jan.kiszka@siemens.com> > >>>> > >>>> Expand bindings to cover both the MCU and the main usage of the AM654 > >>>> system controller. > >>>> > >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > >>>> --- > >>>> .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ > >>>> 1 file changed, 19 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > >>>> index e79803e586ca..cb9da3ec39a8 100644 > >>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > >>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > >>> > >>> As per linux-next, this file does not exist? looks like you might need > >>> to rebase on latest next? > >>> > >> > >> "This goes on top of > >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/" > >> > >> Is that series obsolete by now? > > > > This dependency information would have been useful when provided under the > > diffstat section of the representative patch. :( > > > > Yeah, who reads cover letters? ;) Will try to do that next time. Looking at what we included in v6.11, looks like the above series from krystoff will need to be re-thought through. [1] makes the patches un-necessary to an extent by modelling the node as a simple-bus - Looks like k3-am62-wakeup.dtsi was missed, but it should be trivial enough fixup. Did you try applying the series on latest next? it should not apply anymore (Doesn't apply on master either). [1] https://lore.kernel.org/all/20240628151518.40100-1-afd@ti.com/
On 26.08.24 21:59, Nishanth Menon wrote: > On 14:01-20240826, Jan Kiszka wrote: >> On 26.08.24 13:42, Nishanth Menon wrote: >>> On 13:31-20240826, Jan Kiszka wrote: >>>> On 24.08.24 19:58, Nishanth Menon wrote: >>>>> On 18:37-20240814, Jan Kiszka wrote: >>>>>> From: Jan Kiszka <jan.kiszka@siemens.com> >>>>>> >>>>>> Expand bindings to cover both the MCU and the main usage of the AM654 >>>>>> system controller. >>>>>> >>>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >>>>>> --- >>>>>> .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ >>>>>> 1 file changed, 19 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>>>>> index e79803e586ca..cb9da3ec39a8 100644 >>>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >>>>> >>>>> As per linux-next, this file does not exist? looks like you might need >>>>> to rebase on latest next? >>>>> >>>> >>>> "This goes on top of >>>> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/" >>>> >>>> Is that series obsolete by now? >>> >>> This dependency information would have been useful when provided under the >>> diffstat section of the representative patch. :( >>> >> >> Yeah, who reads cover letters? ;) Will try to do that next time. > > Looking at what we included in v6.11, looks like the above series from > krystoff will need to be re-thought through. > [1] makes the patches un-necessary to an extent by modelling the node as > a simple-bus - Looks like k3-am62-wakeup.dtsi was missed, but it should > be trivial enough fixup. Did you try applying the series on latest next? > it should not apply anymore (Doesn't apply on master either). > > [1] https://lore.kernel.org/all/20240628151518.40100-1-afd@ti.com/ > Krystoff's and my patches still apply on top of master and next. I don't mind via which patches we finally get to zero dtbs_check warnings, just that we get there. Jan
On 22:13-20240826, Jan Kiszka wrote: [..] > I don't mind via which patches we finally get to zero dtbs_check > warnings, just that we get there. Sure. Since we are on the cleanup path towards simple-bus, lets just get there.
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml index e79803e586ca..cb9da3ec39a8 100644 --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml @@ -29,11 +29,30 @@ properties: ranges: true + dss-oldi-io-ctrl@41e0: + type: object + $ref: /schemas/mfd/syscon.yaml# + properties: + compatible: + items: + - const: ti,am654-dss-oldi-io-ctrl + - const: syscon + + clock-controller@4140: + type: object + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# + description: + Clock provider for TI EHRPWM nodes. + patternProperties: "^phy@[0-9a-f]+$": type: object $ref: /schemas/phy/ti,phy-gmii-sel.yaml# + "^clock@[0-9a-f]+$": + type: object + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# + required: - compatible - reg