From patchwork Fri Nov 16 10:04:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10685831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AFC5014E2 for ; Fri, 16 Nov 2018 10:08:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E76728A6A for ; Fri, 16 Nov 2018 10:08:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 927EB29362; Fri, 16 Nov 2018 10:08:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 14C8528A6A for ; Fri, 16 Nov 2018 10:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H+mb9MKdEPStmGeA1/EfE2G1caGMt3NLZAqh/kkthlo=; b=XwcOF8i7/3edgc BrN5oJLCKZzWclSj1ZgqbuK8DSK7oLtZ2xPNSzIiTjhRXJXbdY9b0MYML6jj1vb4nhmKAWxhBpPoN JUmIuha1qAsp7EYm9JoA+GaQ2HbRlu3iYJt6Q8blmwu9iyC5m5zOAyTRbr+M2zeWd4p9Hc13wSJhR qoa+cBeoxJ7LxtICFLGSZZhBDNkauZ2Hm7CaPjvthj9lgwJFX5vg2yl3Kow1kwZ6MJYF5S+wsHqTa qcrf2qcy5MMEev/ig6KQikrIsJsEG/CreMt/gNbVoBBgSSWG/HodD6Ow+th9p0XfjbKf/QLkn2xsS 4T1d/slVJ/EHl33yAVZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNb32-00026f-Cb; Fri, 16 Nov 2018 10:08:24 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNb0O-00080a-GC for linux-arm-kernel@lists.infradead.org; Fri, 16 Nov 2018 10:05:43 +0000 Received: by mail-pf1-x444.google.com with SMTP id b85so4358032pfc.3 for ; Fri, 16 Nov 2018 02:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KuQ2y36Xrogh3AFeo+w7wq6zdpbFBC/erJbwrEPtLJs=; b=jW92B1VzqoIqDzqfecPcu+sFg3tYWXLZGvNmhlicA/IAPUk2KrDwq6Cd/dXpVmP/Ch tc8tdaerC+mPnSf3WEy6lguWwJvNA8r2ShnOFqXsyYp0ajfqyXaQMmd3DuZxDcpGVjul t/MXnPBObHOJLawXqGPkrM4efmpv8szog/bXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KuQ2y36Xrogh3AFeo+w7wq6zdpbFBC/erJbwrEPtLJs=; b=SoOAIChdK0vL2HvzLeW/yhiC6jqf7+fXN84LXHqawN6dRGy5vczABLjjaCK51JDrvY qjV/l/HBPqNxoN5ojjvMTmOOii68GzW+2bnDWZ/lGmWokfbMe+F773w2pVa7/gCdWkzC F6zT26+kY9XIdCuMq+ETV9ygRMF0HHyKI23bHUNhE+jk1Koljs/Y/4yAolm9ZBszA6+t ayqPh/KqN1vx8jxn1/RkivOH6kLxsnlByI98nUiFdYs4Vi0tJzvIx4CwKJAB21Vtf+GU GwrUianRUkjWrgzZ98CeuG+ouhCWf51frEaAyEoCbIgnb/1D4CTjCcLztwrwQ77fk1Zd JL5g== X-Gm-Message-State: AGRZ1gIwbH/VWiItHrkzIX5vTSo2BIGS2lbhIup6cM2W4yTI4nc2W1wD I0hh4tEtF+Mn/4WfZ+OEDDjJjQ== X-Google-Smtp-Source: AJdET5cQ/pFNqQDeGVqoVWAXo3OsGpLnmRROYg1543bE0SKQ5rAbtrwuV09x3/9tqL5x2ckwMAUTtA== X-Received: by 2002:a63:5153:: with SMTP id r19mr9270294pgl.281.1542362733085; Fri, 16 Nov 2018 02:05:33 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id 79sm29801208pge.66.2018.11.16.02.05.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:32 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Masahiro Yamada Subject: [PATCH 10/10] ARM64: dts: uniphier: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:33 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181116_020540_567131_51D6250E X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi index d7e2d8969601..4a0c46cb11cd 100644 --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi @@ -206,13 +206,10 @@ cooling-maps { map0 { trip = <&cpu_alert>; - cooling-device = <&cpu0 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = <&cpu2 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };