| Message ID | cb52d36db90fa24e40fccc69724a685344f2c2f3.1685127525.git.stano.jakubek@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm-mobile: DT cleanup | expand |
Hi Stanislav,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20230525]
[cannot apply to robh/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next v6.4-rc3 v6.4-rc2 v6.4-rc1 linus/master v6.4-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Jakubek/ARM-dts-bcm-mobile-change-includes-to-where-applicable/20230527-033251
base: next-20230525
patch link: https://lore.kernel.org/r/cb52d36db90fa24e40fccc69724a685344f2c2f3.1685127525.git.stano.jakubek%40gmail.com
patch subject: [PATCH 6/6] ARM: dts: bcm28155-ap: use node labels
config: arm-defconfig (https://download.01.org/0day-ci/archive/20230527/202305272120.d14t9kNu-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/42bbea48865bd029be4bb3c33c8d455645e3ff58
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Stanislav-Jakubek/ARM-dts-bcm-mobile-change-includes-to-where-applicable/20230527-033251
git checkout 42bbea48865bd029be4bb3c33c8d455645e3ff58
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305272120.d14t9kNu-lkp@intel.com/
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/bcm59056.dtsi:7.1-5 Label or path pmu not found
>> Error: arch/arm/boot/dts/bcm28155-ap.dts:37.1-5 Label or path pmu not found
>> FATAL ERROR: Syntax error parsing input tree
From: Florian Fainelli <f.fainelli@gmail.com> On Fri, 26 May 2023 21:30:50 +0200, Stanislav Jakubek <stano.jakubek@gmail.com> wrote: > Use node labels instead of nodename@address for BCM28155 AP board > to simplify its DTS file. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
On 6/8/23 15:11, Florian Fainelli wrote: > From: Florian Fainelli <f.fainelli@gmail.com> > > On Fri, 26 May 2023 21:30:50 +0200, Stanislav Jakubek <stano.jakubek@gmail.com> wrote: >> Use node labels instead of nodename@address for BCM28155 AP board >> to simplify its DTS file. >> >> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> >> --- > > Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! Dropped that one since the kernel test robot reported build failures, please fix and resubmit Stanislav, thanks!
On Thu, Jun 08, 2023 at 03:31:28PM -0700, Florian Fainelli wrote: > On 6/8/23 15:11, Florian Fainelli wrote: > > From: Florian Fainelli <f.fainelli@gmail.com> > > > > On Fri, 26 May 2023 21:30:50 +0200, Stanislav Jakubek <stano.jakubek@gmail.com> wrote: > > > Use node labels instead of nodename@address for BCM28155 AP board > > > to simplify its DTS file. > > > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > > --- > > > > Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! > > Dropped that one since the kernel test robot reported build failures, please > fix and resubmit Stanislav, thanks! > -- > Florian > I'm not actually sure how to fix that. The interaction with the bcm59056.dtsi seems pretty weird to me. Though I could just be missing some obvious step, I'm still pretty new at this. Any hints would be appreciated. Stanislav
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts index 0a8ad1d673d8..08eea8b941b6 100644 --- a/arch/arm/boot/dts/bcm28155-ap.dts +++ b/arch/arm/boot/dts/bcm28155-ap.dts @@ -15,64 +15,21 @@ memory@80000000 { device_type = "memory"; reg = <0x80000000 0x40000000>; /* 1 GB */ }; +}; - serial@3e000000 { - status = "okay"; - }; - - i2c@3e016000 { - clock-frequency = <400000>; - status = "okay"; - }; - - i2c@3e017000 { - clock-frequency = <400000>; - status = "okay"; - }; - - i2c@3e018000 { - clock-frequency = <400000>; - status = "okay"; - }; - - i2c@3500d000 { - clock-frequency = <100000>; - status = "okay"; - - pmu: pmu@8 { - reg = <0x08>; - }; - }; - - sdio2: mmc@3f190000 { - non-removable; - max-frequency = <48000000>; - vmmc-supply = <&camldo1_reg>; - vqmmc-supply = <&iosr1_reg>; - status = "okay"; - }; - - sdio4: mmc@3f1b0000 { - max-frequency = <48000000>; - cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>; - vmmc-supply = <&sdldo_reg>; - vqmmc-supply = <&sdxldo_reg>; - status = "okay"; - }; - - pwm: pwm@3e01a000 { - status = "okay"; - }; +&bsc1 { + clock-frequency = <400000>; + status = "okay"; +}; - usbotg: usb@3f120000 { - vusb_d-supply = <&usbldo_reg>; - vusb_a-supply = <&iosr1_reg>; - status = "okay"; - }; +&bsc2 { + clock-frequency = <400000>; + status = "okay"; +}; - usbphy: usb-phy@3f130000 { - status = "okay"; - }; +&bsc3 { + clock-frequency = <400000>; + status = "okay"; }; #include "bcm59056.dtsi" @@ -110,3 +67,46 @@ iosr1_reg: iosr1 { }; }; }; + +&pmu_bsc { + clock-frequency = <100000>; + status = "okay"; + + pmu: pmu@8 { + reg = <0x08>; + }; +}; + +&pwm { + status = "okay"; +}; + +&sdio2 { + non-removable; + max-frequency = <48000000>; + vmmc-supply = <&camldo1_reg>; + vqmmc-supply = <&iosr1_reg>; + status = "okay"; +}; + +&sdio4 { + max-frequency = <48000000>; + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>; + vmmc-supply = <&sdldo_reg>; + vqmmc-supply = <&sdxldo_reg>; + status = "okay"; +}; + +&uartb { + status = "okay"; +}; + +&usbotg { + vusb_d-supply = <&usbldo_reg>; + vusb_a-supply = <&iosr1_reg>; + status = "okay"; +}; + +&usbphy { + status = "okay"; +};
Use node labels instead of nodename@address for BCM28155 AP board to simplify its DTS file. Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- I was not sure what to do about the &pmu node here, so I left it as is. arch/arm/boot/dts/bcm28155-ap.dts | 110 +++++++++++++++--------------- 1 file changed, 55 insertions(+), 55 deletions(-)