| Message ID | ceab1bb4984d0a4f59a580cd9956c1fd6d6a78f3.1566405120.git.agx@sigxcpu.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 968c6f4b3c21e9fae9b49cc91214a01b4827625d |
| Headers | show |
| Series | soc: imx: gpcv2: Print the correct error code | expand |
On Wed, 2019-08-21 at 18:33 +0200, Guido Günther wrote: > The current code prints 'ret' (thus 0) while it should use 'err'. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > drivers/soc/imx/gpcv2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 31b8d002d855..b0dffb06c05d 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct > generic_pm_domain *genpd, > err = regulator_disable(domain->regulator); > if (err) > dev_err(domain->dev, > - "failed to disable regulator: %d\n", > ret); > + "failed to disable regulator: %d\n", > err); > /* Preserve earlier error code */ > ret = ret ?: err; > }
On Wed, Aug 21, 2019 at 06:33:04PM +0200, Guido Günther wrote: > The current code prints 'ret' (thus 0) while it should use 'err'. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Applied, thanks.
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 31b8d002d855..b0dffb06c05d 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, err = regulator_disable(domain->regulator); if (err) dev_err(domain->dev, - "failed to disable regulator: %d\n", ret); + "failed to disable regulator: %d\n", err); /* Preserve earlier error code */ ret = ret ?: err; }
The current code prints 'ret' (thus 0) while it should use 'err'. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- drivers/soc/imx/gpcv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)