| Message ID | d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: > The probe() function now prints the hardware version of the I2C > controller. > Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> > --- > drivers/i2c/busses/i2c-at91.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > index 817ae69..6e88b30 100644 > --- a/drivers/i2c/busses/i2c-at91.c > +++ b/drivers/i2c/busses/i2c-at91.c [...] > @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev) > return rc; > } > > - dev_info(dev->dev, "AT91 i2c bus driver.\n"); > + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", It looks as if you rather print the driver's version. :-) > + at91_twi_read(dev, AT91_TWI_VER)); > return 0; > } WBR, Sergei
On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote: > Hello. > > On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: > > >The probe() function now prints the hardware version of the I2C > >controller. > > >Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> > >--- > > drivers/i2c/busses/i2c-at91.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > >diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > >index 817ae69..6e88b30 100644 > >--- a/drivers/i2c/busses/i2c-at91.c > >+++ b/drivers/i2c/busses/i2c-at91.c > [...] > >@@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev) > > return rc; > > } > > > >- dev_info(dev->dev, "AT91 i2c bus driver.\n"); > >+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", > > It looks as if you rather print the driver's version. :-) From my point of view, having a version number for a Linux driver would be strange so it's not confusing. > > >+ at91_twi_read(dev, AT91_TWI_VER)); > > return 0; > > } > > WBR, Sergei > Regards Ludovic
Hello. On 6/10/2015 11:05 AM, Ludovic Desroches wrote: >>> The probe() function now prints the hardware version of the I2C >>> controller. >>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> >>> --- >>> drivers/i2c/busses/i2c-at91.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c >>> index 817ae69..6e88b30 100644 >>> --- a/drivers/i2c/busses/i2c-at91.c >>> +++ b/drivers/i2c/busses/i2c-at91.c >> [...] >>> @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev) >>> return rc; >>> } >>> >>> - dev_info(dev->dev, "AT91 i2c bus driver.\n"); >>> + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", >> It looks as if you rather print the driver's version. :-) > From my point of view, having a version number for a Linux driver would > be strange Not everybody shares your opinion. > so it's not confusing. Oh, it is, from the purely grammatical PoV. Addiung "hardware " to "version" (or not mentioning the driver at all) would clear up that confusion. >> >>> + at91_twi_read(dev, AT91_TWI_VER)); >>> return 0; >>> } >> WBR, Sergei > Regards > Ludovic WBR, Sergei
> >>>- dev_info(dev->dev, "AT91 i2c bus driver.\n"); > >>>+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", > > >> It looks as if you rather print the driver's version. :-) > > > From my point of view, having a version number for a Linux driver would > >be strange > > Not everybody shares your opinion. I tend to agree with Sergei but let's keep things simple: I'll make it "hw version" before applying.
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 817ae69..6e88b30 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/drivers/i2c/busses/i2c-at91.c @@ -85,6 +85,8 @@ #define AT91_TWI_ACR_DATAL(len) ((len) & 0xff) #define AT91_TWI_ACR_DIR BIT(8) +#define AT91_TWI_VER 0x00fc /* Version Register */ + struct at91_twi_pdata { unsigned clk_max_div; unsigned clk_offset; @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev) return rc; } - dev_info(dev->dev, "AT91 i2c bus driver.\n"); + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", + at91_twi_read(dev, AT91_TWI_VER)); return 0; }
The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)