| Message ID | d5c297680eb82fd7ef63f7f5dafffc22b98d2345.1488555615.git.peter.senna@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 03, 2017 at 04:57:10PM +0100, Peter Senna Tschudin wrote: Hi Shawn Guo, Now that the driver and binding are in, can you pick this up? Thank you! > Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Martyn Welch <martyn.welch@collabora.co.uk> > Cc: Martin Donnelly <martin.donnelly@ge.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com> > --- > Unchanged since V1. > > arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts > index b237429..3ec54da 100644 > --- a/arch/arm/boot/dts/imx6q-b850v3.dts > +++ b/arch/arm/boot/dts/imx6q-b850v3.dts > @@ -72,6 +72,13 @@ > fsl,data-mapping = "spwg"; > fsl,data-width = <24>; > status = "okay"; > + > + port@4 { > + reg = <4>; > + lvds0_out: endpoint { > + remote-endpoint = <&stdp4028_in>; > + }; > + }; > }; > }; > > @@ -146,3 +153,64 @@ > &usdhc2 { > status = "disabled"; > }; > + > +&mux2_i2c2 { > + status = "okay"; > + clock-frequency = <100000>; > + > + stdp4028@73 { > + compatible = "megachips,stdp4028-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x73>; > + > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp4028_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + port@1 { > + reg = <1>; > + stdp4028_out: endpoint { > + remote-endpoint = <&stdp2690_in>; > + }; > + }; > + }; > + }; > + > + stdp2690@72 { > + compatible = "megachips,stdp2690-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x72>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp2690_in: endpoint { > + remote-endpoint = <&stdp4028_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + stdp2690_out: endpoint { > + /* Connector for external display */ > + }; > + }; > + }; > + }; > +}; > -- > 2.9.3 >
On Fri, Mar 03, 2017 at 04:57:10PM +0100, Peter Senna Tschudin wrote: > Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Martyn Welch <martyn.welch@collabora.co.uk> > Cc: Martin Donnelly <martin.donnelly@ge.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com> > --- > Unchanged since V1. > > arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts > index b237429..3ec54da 100644 > --- a/arch/arm/boot/dts/imx6q-b850v3.dts > +++ b/arch/arm/boot/dts/imx6q-b850v3.dts > @@ -72,6 +72,13 @@ > fsl,data-mapping = "spwg"; > fsl,data-width = <24>; > status = "okay"; > + > + port@4 { > + reg = <4>; Have a newline between property list and child node. > + lvds0_out: endpoint { > + remote-endpoint = <&stdp4028_in>; > + }; > + }; > }; > }; > > @@ -146,3 +153,64 @@ > &usdhc2 { > status = "disabled"; > }; > + > +&mux2_i2c2 { > + status = "okay"; This okay status doesn't seem really necessary to me. If it does, please put it at the end of property list. > + clock-frequency = <100000>; > + > + stdp4028@73 { > + compatible = "megachips,stdp4028-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + Drop this newline, as in general we do not add newline in middle of property list. > + reg = <0x73>; > + Ditto > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp4028_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; Have a newline between nodes. > + port@1 { > + reg = <1>; > + stdp4028_out: endpoint { > + remote-endpoint = <&stdp2690_in>; > + }; > + }; > + }; > + }; > + > + stdp2690@72 { Sort device nodes under bus in order of unit address. That said, stdp2690@72 should go before stdp4028@73. Shawn > + compatible = "megachips,stdp2690-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x72>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp2690_in: endpoint { > + remote-endpoint = <&stdp4028_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + stdp2690_out: endpoint { > + /* Connector for external display */ > + }; > + }; > + }; > + }; > +}; > -- > 2.9.3 >
diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts index b237429..3ec54da 100644 --- a/arch/arm/boot/dts/imx6q-b850v3.dts +++ b/arch/arm/boot/dts/imx6q-b850v3.dts @@ -72,6 +72,13 @@ fsl,data-mapping = "spwg"; fsl,data-width = <24>; status = "okay"; + + port@4 { + reg = <4>; + lvds0_out: endpoint { + remote-endpoint = <&stdp4028_in>; + }; + }; }; }; @@ -146,3 +153,64 @@ &usdhc2 { status = "disabled"; }; + +&mux2_i2c2 { + status = "okay"; + clock-frequency = <100000>; + + stdp4028@73 { + compatible = "megachips,stdp4028-ge-b850v3-fw"; + #address-cells = <1>; + #size-cells = <0>; + + reg = <0x73>; + + interrupt-parent = <&gpio2>; + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + stdp4028_in: endpoint { + remote-endpoint = <&lvds0_out>; + }; + }; + port@1 { + reg = <1>; + stdp4028_out: endpoint { + remote-endpoint = <&stdp2690_in>; + }; + }; + }; + }; + + stdp2690@72 { + compatible = "megachips,stdp2690-ge-b850v3-fw"; + #address-cells = <1>; + #size-cells = <0>; + + reg = <0x72>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + stdp2690_in: endpoint { + remote-endpoint = <&stdp4028_out>; + }; + }; + + port@1 { + reg = <1>; + stdp2690_out: endpoint { + /* Connector for external display */ + }; + }; + }; + }; +};
Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE B850v3 dts file. Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Martyn Welch <martyn.welch@collabora.co.uk> Cc: Martin Donnelly <martin.donnelly@ge.com> Cc: Javier Martinez Canillas <javier@dowhile0.org> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Herring <robh@kernel.org> Cc: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com> --- Unchanged since V1. arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+)